Repository navigation
Fix TypeVarTuple with defaulted ParamSpec - #22378
Draft
Udit-Agarwal20 wants to merge 1 commit into
Draft
Udit-Agarwal20 wants to merge 1 commit into
Udit-Agarwal20 wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22375.
Summary
Fix incorrect type argument binding when a
TypeVarTupleis followed by a defaultedParamSpec, as permitted by PEP 696.Previously, mypy incorrectly assigned arguments intended for
TypeVarTupleto the trailingParamSpec. This produced invalid substitution errors and caused inferred types to degrade toAny.Changes
ParamSpecparameters.Example
Both specializations now preserve the expected types without erroneous ParamSpec substitution errors.
Testing
Local verification on macOS with Python 3.13:
git diff --checkpassed.Linux, Windows, and mypyc-compiled configurations remain to be validated by GitHub Actions.