Repository navigation
TPC: rate-limit TPCScaler weight errors - #16027
Merged
wiechula merged 1 commit intoNov 11, 2026
Merged
Conversation
TPCScalerWeights::getWeight logged an error for every scaler value outside the stored weights. For a timestamp within the first ion drift time of a TPCScaler object (e.g. at the start of a run) the clamped averaging range extends beyond the timestamp, which produced hundreds of identical error lines per call. The weight (1) is unchanged; getMeanScaler now counts these values and reports them in one line per call, at most 20 times per process. Co-Authored-By: Claude Opus 5.5 <[email protected]>
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
October 31, 2026 21:39
shahor02
approved these changes
Oct 31, 2026
wiechula
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TPCScalerWeights::getWeight logged an error for every scaler value outside the stored weights. For a timestamp within the first ion drift time of a TPCScaler object (e.g. at the start of a run) the clamped averaging range extends beyond the timestamp, which produced hundreds of identical error lines per call. The weight (1) is unchanged; getMeanScaler now counts these values and reports them in one line per call, at most 20 times per process.