Repository navigation
FST: detect detectors with no raw data also on macOS - #16077
Merged
Merged
Conversation
The check for detectors that produced only empty raw files compared the output of wc -l with "0". BSD wc, as on macOS, pads its count with spaces, so the comparison never matched and an empty raw output went unnoticed: the TRD raw files of a run were all empty, and the test only failed later, when no CTF had been written. grep -c prints the bare count on every platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for detectors that produced only empty raw files compared the
output of wc -l with "0". BSD wc, as on macOS, pads its count with
spaces, so the comparison never matched and an empty raw output went
unnoticed: the TRD raw files of a run were all empty, and the test only
failed later, when no CTF had been written. grep -c prints the bare count
on every platform.