Repository navigation
Resolve TPC digitizer calibration objects once per sector - #16083
Merged
Merged
Conversation
This moves the calibration lookups of the TPC DigitContainer out of the flush loop. - fillOutputContainer fetched the ion-tail and common-mode pad parameters, the dead channel map and the FEE config from the CDBInterface on every flush, the FEE config even once per time bin. - getDeadChannelMap() rebuilds the dead channel map from the pad flags on every call. - updateCalibrations() now fetches them once per sector from Digitizer::init(), with a fallback on the first flush for callers that do not call init(). - SAMPAProcessing picks up its pointers after this update, because a FEE parameter file reload replaces the objects it points to. https://its.cern.ch/jira/browse/O2-7309 Co-Authored-By: Claude Opus 5.5 <[email protected]>
sawenzel
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
November 9, 2026 08:44
wiechula
approved these changes
Nov 9, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes repeated calibration lookups in the TPC digitizer and is a preparation for multithreaded TPC digitization.
DigitContainer::fillOutputContainerfetched its calibration objects from theCDBInterfaceon every flush: the ion-tail and common-mode pad parameters, the dead-channel map (rebuilt from the pad flags on each call), and the FEE config (even once per time bin). They are now fetched once per sector inDigitizer::init(), so worker threads will not need to touch theCDBInterface.Digits, labels and common mode are unchanged (checked on PbPb and pp). The one exception is
IonTailSettings.padITCorrFile: the old code then letSAMPAProcessingread freed calibration maps for the first sector, which this change fixes.https://its.cern.ch/jira/browse/O2-7309
Assisted by Claude Code.