Skip to content

[Common,DPG] TPC PID workflows: provide reproducibility of randomization #18634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alcaliva merged 2 commits into from
Nov 10, 2026
Merged

[Common,DPG] TPC PID workflows: provide reproducibility of randomization #18634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ad69b8
seed rnd with timestamp
lubynets Nov 6, 2026
d48785f
do not leave uninitialized variables
lubynets Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Common/Tools/PID/pidTPCModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,11 @@ class pidTPCModule
}
auto trackiterator = tracks.begin();
if constexpr (requires { trackiterator.mcParticleId(); }) {
gRandom->SetSeed(0); // Ensure unique seed from UUID for each process call
if (bcs.size() != 0) {
const auto timestamp = bcs.begin().timestamp();
LOG(info) << "gRandom is seeded with timestamp of the 0-th bunch crossing (" << timestamp << ")";
gRandom->SetSeed(timestamp);
}
}

// preparatory step: we need the multiplicities for each collision
Expand Down
44 changes: 28 additions & 16 deletions DPG/Tasks/TPC/tpcSkimsTableCreator.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ struct TreeWriterTpcV0 {

o2::aod::rctsel::RCTFlagsChecker rctChecker{};

TRandom3* fRndm = new TRandom3(0);
TRandom3* fRndm = new TRandom3();

using Trks = soa::Join<aod::Tracks, aod::V0Bits, aod::TracksExtra, aod::pidTPCFullEl, aod::pidTPCFullPi, aod::pidTPCFullKa, aod::pidTPCFullPr, aod::pidTOFFullEl, aod::pidTOFFullPi, aod::pidTOFFullKa, aod::pidTOFFullPr, aod::TrackSelection>;
using TrksWithDEdxCorrection = soa::Join<Trks, aod::DEdxsCorrected>;
Expand Down Expand Up @@ -420,6 +420,12 @@ struct TreeWriterTpcV0 {
template <bool IsCorrectedDeDx, int ModeId, typename TrksType, typename BCType, typename TrkQAType>
void runV0(Colls const& collisions, TrksType const& myTracks, V0sWithID const& myV0s, CascsWithID const& myCascs, TrkQAType const& tracksQA)
{
if (collisions.size() != 0) {
const auto timestamp = collisions.begin().bc_as<BCType>().timestamp();
LOG(info) << "fRndm is seeded with timestamp of the 0-th bunch crossing (" << timestamp << ")";
fRndm->SetSeed(timestamp);
}

constexpr bool IsWithTrackQa = ModeId != ModeStandard;

std::vector<int64_t> labelTrack2TrackQA;
Expand Down Expand Up @@ -692,20 +698,20 @@ struct TreeWriterTpcTof {
HistogramRegistry registry{"registry", {}};

struct TofTrack {
bool isApplyHardCutOnly;
double maxMomHardCutOnly;
double maxMomTPCOnly;
double tpcNSigma;
double nSigmaTPCOnly;
double downsamplingTsalis;
double mass;
double tofNSigma;
double itsNSigma;
double tpcExpSignal;
o2::track::PID::ID pid;
double dwnSmplFactor;
double nSigmaTofTpctof;
double nSigmaTpcTpctof;
bool isApplyHardCutOnly{false};
double maxMomHardCutOnly{UndefValueDouble};
double maxMomTPCOnly{UndefValueDouble};
double tpcNSigma{UndefValueDouble};
double nSigmaTPCOnly{UndefValueDouble};
double downsamplingTsalis{UndefValueDouble};
double mass{UndefValueDouble};
double tofNSigma{UndefValueDouble};
double itsNSigma{UndefValueDouble};
double tpcExpSignal{UndefValueDouble};
o2::track::PID::ID pid{0};
double dwnSmplFactor{UndefValueDouble};
double nSigmaTofTpctof{UndefValueDouble};
double nSigmaTpcTpctof{UndefValueDouble};
};

Service<o2::ccdb::BasicCCDBManager> ccdb{};
Expand All @@ -714,7 +720,7 @@ struct TreeWriterTpcTof {

o2::aod::rctsel::RCTFlagsChecker rctChecker{};

TRandom3* fRndm = new TRandom3(0);
TRandom3* fRndm = new TRandom3();

using Trks = soa::Join<aod::Tracks, aod::TracksExtra,
aod::pidTPCFullEl, aod::pidTPCFullPi, aod::pidTPCFullKa,
Expand Down Expand Up @@ -850,6 +856,12 @@ struct TreeWriterTpcTof {
template <bool IsCorrectedDeDx, int ModeId, typename TrksType, typename BCType, typename TrkQAType, typename TMOType>
void runTof(Colls const& collisions, TrksType const& myTracks, TrkQAType const& tracksQA, Preslice<TrksType> const& perCollisionTracksType, TMOType const& trackMeanOccs)
{
if (collisions.size() != 0) {
const auto timestamp = collisions.begin().bc_as<BCType>().timestamp();
LOG(info) << "fRndm is seeded with timestamp of the 0-th bunch crossing (" << timestamp << ")";
fRndm->SetSeed(timestamp);
}

constexpr bool IsWithTrackQa = ModeId != ModeStandard;

std::vector<int64_t> labelTrack2TrackQA;
Expand Down
10 changes: 10 additions & 0 deletions DPG/Tasks/TPC/treeCreatorPidTpcDiagnostics.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,16 @@ struct TreeCreatorPidTpcDiagnostics {
}
}

void process(const aod::Collisions& collisions,
const aod::BCsWithTimestamps&)
{
if (collisions.size() != 0) {
const auto timestamp = collisions.begin().bc_as<aod::BCsWithTimestamps>().timestamp();
LOG(info) << "mRnd is seeded with timestamp of the 0-th bunch crossing (" << timestamp << ")";
mRnd.SetSeed(timestamp);
}
}

#define MAKE_PROCESS_FUNCTIONS(ParticleNameShort, ParticleNameLong, Unused) \
void process##ParticleNameLong(CollisionsExtra const& collisions, \
soa::Join<TrackCandidates, aod::pidTPC##ParticleNameShort> const& tracks, \
Expand Down
Loading