[PWGCF] Add a new file for pid v2 in events with at least 1 cascades by fuchuncui · Pull Request #18681 · AliceO2Group/O2Physics

fuchuncui · 2026-11-10T10:31:02Z

New file for cascades events v2, based on preet's code pidDihadron.cxx.
fix a bug for event selection in OO cascades v2 calculation.

github-actions · 2026-11-10T10:31:31Z

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

alibuild · 2026-11-10T18:50:50Z

Error while checking build/O2Physics/code-check for b972e68 at 2026-11-10 19:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 8 errors and 313 warnings.'
Found 8 errors and 313 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/30b337f526d9abdacccfac59f8c14e177b046cd3/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:204:199: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:815:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:827:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1095:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1194:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1301:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadronWithCasc.cxx:262:238: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadronWithCasc.cxx:2091:52: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 313 -gt 0 ]]
++ cat /sw/BUILD/30b337f526d9abdacccfac59f8c14e177b046cd3/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:65:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:67:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:262:29: warning: use designated initializer list to initialize 'ValidParticle' [modernize-use-designated-initializers]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:320:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:322:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:325:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:327:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:330:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:332:56: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:335:54: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:337:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:372:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:474:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:507:11: warning: variable 'cent' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:556:116: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:558:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:560:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:562:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:564:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:566:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:582:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:584:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:586:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:588:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:590:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:592:64: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

wenyaCern · 2026-11-10T20:19:51Z

Error while checking build/O2Physics/code-check for b972e68 at 2026-11-10 19:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 8 errors and 313 warnings.'
Found 8 errors and 313 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/30b337f526d9abdacccfac59f8c14e177b046cd3/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:204:199: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:815:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:827:27: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1095:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1194:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:1301:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadronWithCasc.cxx:262:238: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/pidDiHadronWithCasc.cxx:2091:52: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 313 -gt 0 ]]
++ cat /sw/BUILD/30b337f526d9abdacccfac59f8c14e177b046cd3/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:65:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:67:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:262:29: warning: use designated initializer list to initialize 'ValidParticle' [modernize-use-designated-initializers]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:320:52: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:322:53: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:325:50: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:327:51: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:330:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:332:56: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:335:54: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:337:55: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:372:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:474:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:507:11: warning: variable 'cent' is not initialized [cppcoreguidelines-init-variables]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:556:116: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:558:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:560:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:562:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:564:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:566:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:582:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:584:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:586:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:588:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:590:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:592:64: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Dear @fuchuncui , please check and fix the errors

alibuild · 2026-11-11T05:43:09Z

Error while checking build/O2Physics/code-check for 92e8e5e at 2026-11-11 06:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 1 warnings.'
Found 2 errors and 1 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/5f8b5b76db509e795dc7c068920b60b266c62c3a/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:876:23: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:888:27: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/5f8b5b76db509e795dc7c068920b60b266c62c3a/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/cascDiHadronCorr.cxx:65:78: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

fuchuncui added 3 commits November 10, 2026 18:25

Add files via upload

a40cdfe

Add files via upload

48f37db

Add files via upload

6d0652f

github-actions Bot added the pwgcf label Nov 10, 2026

github-actions Bot changed the title ~~[PWGCF] Add a new file for pid v2 in events with at least 1 cascades~~ [PWGCF] Add a new file for pid v2 in events with at least 1 cascades Nov 10, 2026

alibuild mentioned this pull request Nov 10, 2026

[PWGCF] Please consider the following formatting changes to #18681 fuchuncui/O2Physics#39

Closed

fuchuncui added 2 commits November 10, 2026 18:42

Add files via upload

45abeec

Add files via upload

b972e68

fuchuncui marked this pull request as ready for review November 10, 2026 11:01

fuchuncui requested review from alibuild, dsarkaralice, jaelpark, lauraser, victor-gonzalez and wenyaCern as code owners November 10, 2026 11:01

wenyaCern previously approved these changes Nov 10, 2026

View reviewed changes

Add files via upload

92e8e5e

fuchuncui dismissed wenyaCern’s stale review via 92e8e5e November 11, 2026 02:21

Add files via upload

b70ba27

wenyaCern enabled auto-merge (squash) November 11, 2026 12:18

Empty commit to open PR

e7f0125

fuchuncui requested a review from wenyaCern November 11, 2026 15:38

fuchuncui added 4 commits November 11, 2026 23:43

Empty commit to open PR

b85b18d

Empty commit to open PR

4aff385

Empty commit to open PR

a48e450

Empty commit to open PR

c3a5139

wenyaCern approved these changes Nov 11, 2026

View reviewed changes

wenyaCern merged commit fbb82d3 into AliceO2Group:master Nov 11, 2026
13 of 14 checks passed

Navigation Menu

Repository navigation

[PWGCF] Add a new file for pid v2 in events with at least 1 cascades - #18681

[PWGCF] Add a new file for pid v2 in events with at least 1 cascades#18681
wenyaCern merged 12 commits into
AliceO2Group:masterfrom
fuchuncui:master

fuchuncui commented Nov 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 10, 2026

Uh oh!

alibuild commented Nov 10, 2026

Uh oh!

wenyaCern commented Nov 10, 2026

Uh oh!

alibuild commented Nov 11, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

fuchuncui commented Nov 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 10, 2026

Uh oh!

alibuild commented Nov 10, 2026

Uh oh!

wenyaCern commented Nov 10, 2026

Uh oh!

alibuild commented Nov 11, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

fuchuncui commented Nov 10, 2026 •

edited

Loading