Skip to content

[PWGLF] fixed the mixing logic which is now run time configurable for all cen… - #18687

Merged
mpuccio merged 3 commits into
AliceO2Group:masterfrom
bhattdurgesh921-sys:master
Nov 12, 2026
Merged

mpuccio merged 3 commits into
AliceO2Group:masterfrom
bhattdurgesh921-sys:master

Conversation

@bhattdurgesh921-sys

Copy link
Copy Markdown
Contributor

In this PR , we fix the event mixing logic which was previously not a run time configurable for the selected centrality classes.

@github-actions github-actions Bot added the pwglf label Nov 11, 2026
@github-actions github-actions Bot changed the title fixed the mixing logic which is now run time configurable for all cen… [PWGLF] fixed the mixing logic which is now run time configurable for all cen… Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

mpuccio
mpuccio previously approved these changes Nov 11, 2026
@mpuccio
mpuccio enabled auto-merge (squash) November 11, 2026 08:12
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f647971 at 2026-11-11 09:42:

## sw/BUILD/O2Physics-latest/log
2026-11-11T09:40:50.474+0100 [36175:140040528435264] [buildboxcommon_grpcretrier.cpp:134] [ERROR] ByteStream.Read() failed with: 5: Failed to replicate blob 1-8af49ee6ccca9f6ed018dbb62f14e328b73308f426299ce9f955e2de2dfead53-5583008-bar: 1-8af49ee6ccca9f6ed018dbb62f14e328b73308f426299ce9f955e2de2dfead53-5583008-bar: Object not found
2026-11-11T09:40:50.479+0100 [36175:140040528435264] [executioncontext.cpp:739] [ERROR] 1 output blobs missing from ActionResult: 8af49ee6ccca9f6ed018dbb62f14e328b73308f426299ce9f955e2de2dfead53
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled November 11, 2026 12:13

Head branch was pushed to by a user without write access

…tograms in the code and remove the usage of some tables.
@mpuccio
mpuccio merged commit b2b09f4 into AliceO2Group:master Nov 12, 2026
14 checks passed
@dmallick2

Copy link
Copy Markdown
Collaborator

@bhattdurgesh921-sys . Please make PR title clear what changes were made that can be followed up. Regarding spin alignment studies for L(1520) , there were already a code prepared for the same (https://github.com/AliceO2Group/O2Physics/blob/master/PWGLF/Tasks/Resonances/lambda1520pbpb.cxx) . if you want to made your own same thing with additional new task according to your convenient task but mention it in clear way in PR, adding a new task there is no issue as several analysis task already available for same analysis . Run 3 analysis, we are not strictly following adding analysis task structure or maintenance as it is approved by several people. I would request please add the PR title and changes so that people can follow and conflict will not arise in future among the analyzer we faced the same situation in past.

@bhattdurgesh921-sys

Copy link
Copy Markdown
Contributor Author

@dmallick2 Thank you for your valuable feedback and suggestions. We appreciate your clarification regarding the existing analysis task and the importance of clearly documenting the changes introduced through the PR.
We will certainly take these points into consideration in all our future PRs, ensuring that the titles and descriptions accurately reflect the modifications and provide sufficient clarity to avoid any potential conflicts or confusion among analyzers.
Thank you for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants