Repository navigation
[PWGCF] Update EbyE partNumFluc for MC particle - track match - #18719
Merged
Merged
Conversation
fsii
requested review from
SwatiSaha-1997,
alibuild,
dsarkaralice,
isputows,
lauraser and
victor-gonzalez
as code owners
November 12, 2026 16:33
|
O2 linter results: ❌ 0 errors, |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the particle–track matching update.
No open issues 🎉
What changed in this PR
Updates Monte Carlo particle–track matching in the event-by-event particle-number fluctuation task, replacing nested slicing with explicit collision filtering.
Changes:
- Slice ungrouped tracks by MC particle, then filter by collision for mini-table storage and analysis.
- Count collision-matched tracks explicitly for acceptance checks and quality-assurance histograms.
- Replace the remaining
C_CSandC_SVwrappers with directHISTcalls and make minor C++ cleanups.
| File | Description |
|---|---|
PWGCF/EbyEFluctuations/Tasks/partNumFluc.cxx |
Revises MC particle–track matching and removes histogram macro wrappers. |
Review effort: Balanced
Collaborator
Author
|
Hi @vkucera , the errors reported by the check on macOS-arm seem not relevant to my changed code. Could you please tell me how to fix them? Thanks! |
fsii
enabled auto-merge (squash)
November 13, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sliceBy)C_CSandC_SV, both were added by PR15976 to avoid errors on macOS-arm (pass on Linux-x64), modified back toHISTby PR18584