Repository navigation
Conversation
|
O2 linter results: ❌ 0 errors, |
|
Error while checking build/O2Physics/code-check for 4620b42 at 2026-11-13 19:19: Full log here. |
[Tutorial,PWGLF] Please consider the following formatting changes to AliceO2Group#18740
|
Error while checking build/O2Physics/code-check for 669a8b9 at 2026-11-13 19:27: Full log here. |
|
Error while checking build/O2Physics/code-check for 23ac5cd at 2026-11-13 19:33: Full log here. |
|
Error while checking build/O2Physics/code-check for 6907bed at 2026-11-13 19:33: Full log here. |
[Tutorial,PWGLF] [MegaLinter] Apply linters automatic fixes to AliceO2Group#18740
There was a problem hiding this comment.
Hi @spucillo ! Thank you very much for preparing the hands-on tasks!
It looks great!
I just have a few comments:
- Since these are all tasks running over derived data, could you put everything within
Tutorials/PWGLF/Strangeness/Derived - could you also rename the folder
o2physics/AnalysisV0intoAnalysisV0? (since we are already working withinO2Physics). Similarly, the existing folderAnalysiswithinTutorials/PWGLF/Strangeness/Derivedcould be renamedAnalysisCascade - could you please remove the
input_data.txtandinput_MC.txt? We usually don't put them in O2Physics and just provide them in slides for the hands-on session.
Thank you very much!
# Conflicts: # Tutorials/PWGLF/Strangeness/Derived/AnalysisV0/README.md
[Tutorial,PWGLF] [MegaLinter] Apply linters automatic fixes to AliceO2Group#18740
|
Hi @romainschotter, Thanks a lot for the review! I moved everything into Tutorials/PWGLF/Strangeness/Derived/AnalysisV0, organized in the same way as the existing cascade folder, and removed input_data.txt and input_MC.txt (the README now explains how to create them). I left the existing Analysis folder unchanged, since renaming it would also require updating the cascade tutorial material. All the checks are now passing, so the PR should be ready for another look. Let me know if anything else needs to be changed! |
No description provided.