Repository navigation
Scenario workflow: 13. generic osw step helpers - #21
Merged
JieXiong9119 merged 1 commit intoNov 11, 2026
Merged
JieXiong9119 merged 1 commit into
JieXiong9119 merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the OSW step helper and scenario workflow changes.
No open issues 🎉
What changed in this PR
Centralizes OSW step creation and argument updates for BOSS scenario workflows, keeping repeated measures independent while preserving baseline generation behavior.
Changes:
- Adds helpers for deep-copying steps, ordered insertion, and step-specific argument updates.
- Reuses the helpers in baseline populators and scenario workflow assembly.
- Adds tests for argument serialization, insertion order, and copy isolation, and updates the roadmap.
| File | Description |
|---|---|
spec/tests/unit/osw_arg_populator_spec.rb |
Tests argument types, insertion order, and independent step copies. |
spec/tests/unit/boss_spec.rb |
Tests scenario assembly with repeated measures and unchanged inputs. |
lib/BOSS/osw_arg_populator.rb |
Adds shared step helpers and adopts them in baseline populators. |
lib/BOSS/boss.rb |
Uses the shared append helper for mapped scenario steps. |
docs/scenario_workflow_translation_plan.md |
Updates roadmap status and records helper behavior and verification. |
Review effort: Balanced
JieXiong9119
deleted the
scenario-workflow-13-generic-osw-step-helpers
branch
November 11, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.