Skip to content

Scenario workflow: 13. generic osw step helpers - #21

Merged
JieXiong9119 merged 1 commit into
scenario-workflowfrom
scenario-workflow-13-generic-osw-step-helpers
Nov 11, 2026
Merged

JieXiong9119 merged 1 commit into
scenario-workflowfrom
scenario-workflow-13-generic-osw-step-helpers

Conversation

@JieXiong9119

Copy link
Copy Markdown

No description provided.

@JieXiong9119 JieXiong9119 self-assigned this Nov 10, 2026
@JieXiong9119
JieXiong9119 changed the base branch from develop to scenario-workflow November 11, 2026 18:35
@JieXiong9119
JieXiong9119 requested a balanced review from Copilot November 11, 2026 18:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the OSW step helper and scenario workflow changes.

No open issues 🎉

What changed in this PR

Centralizes OSW step creation and argument updates for BOSS scenario workflows, keeping repeated measures independent while preserving baseline generation behavior.

Changes:

  • Adds helpers for deep-copying steps, ordered insertion, and step-specific argument updates.
  • Reuses the helpers in baseline populators and scenario workflow assembly.
  • Adds tests for argument serialization, insertion order, and copy isolation, and updates the roadmap.
File Description
spec/​tests/​unit/​osw_arg_populator_spec.rb Tests argument types, insertion order, and independent step copies.
spec/​tests/​unit/​boss_spec.rb Tests scenario assembly with repeated measures and unchanged inputs.
lib/​BOSS/​osw_arg_populator.rb Adds shared step helpers and adopts them in baseline populators.
lib/​BOSS/​boss.rb Uses the shared append helper for mapped scenario steps.
docs/​scenario_workflow_translation_plan.md Updates roadmap status and records helper behavior and verification.

Review effort: Balanced

@JieXiong9119
JieXiong9119 merged commit e6f1fb0 into scenario-workflow Nov 11, 2026
2 checks passed
@JieXiong9119
JieXiong9119 deleted the scenario-workflow-13-generic-osw-step-helpers branch November 11, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants