Skip to content

[ENG-12605] 1. User gets error trying to submit registration - #1098

Merged
brianjgeiger merged 2 commits into
CenterForOpenScience:feature/pbs-26-22from
sh-andriy:fix/ENG-12605
Nov 12, 2026
Merged

brianjgeiger merged 2 commits into
CenterForOpenScience:feature/pbs-26-22from
sh-andriy:fix/ENG-12605

Conversation

@sh-andriy

Copy link
Copy Markdown
Collaborator

Purpose

Users couldn't submit a registration created from scratch when files were attached. Deleting a file from the file list only removed it from the question on the current page. If the same file was attached on another page, that answer kept pointing to the deleted file and submit failed with "All files attached to this form must be registered...". Re-uploading didn't help because the old file still showed up there with the same name.

Summary of Changes

  1. Deleting a file now removes it from every file question in the draft, not only the one on the current page.
  2. Newly attached files are stored in the same shape as saved ones, so the duplicate check and removal work right after attaching.
  3. Updated unit tests.

Screenshot(s)

n/a

Side Effects

Deleting a file can now also update file answers on other pages of the draft.

QA Notes

  1. Create a new registration with no project, using a template that has file questions on more than one page (e.g. Generalized Systematic Review).
  2. Attach the same file on two pages.
  3. On one of the pages delete the file from the list and upload it again.
  4. Go back to the other page, the deleted file should no longer be attached there.
  5. Attach the files you need and submit, it should go through without the files error.

@brianjgeiger
brianjgeiger requested a review from nsemets November 10, 2026 13:55
@sh-andriy
sh-andriy requested a review from nsemets November 12, 2026 12:59
@brianjgeiger
brianjgeiger merged commit 11388bd into CenterForOpenScience:feature/pbs-26-22 Nov 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants