Skip to content

ci: move macro jobs to the x64 macro runner - #119

Open
not-matthias wants to merge 3 commits into
mainfrom
cod-4140-migrate-gen2-macro-runners
Open

not-matthias wants to merge 3 commits into
mainfrom
cod-4140-migrate-gen2-macro-runners

Conversation

@not-matthias

@not-matthias not-matthias commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Move the macro runner jobs from codspeed-macro to codspeed-macro-x64-ryzen-9950x-ubuntu-24-04.

  • codspeed-walltime and electron-e2e now use the x64 macro runner.
  • electron-e2e now uses runner-version: latest instead of the v4.17.7-alpha.2 pin.
  • The electron e2e example passes --disable-dev-shm-usage, so Chromium keeps shared memory in /tmp.
  • Benchmark history starts a new baseline on the new runner.

Refs COD-4140

@codspeed

codspeed Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Hooray! CodSpeed harness just leveled up!

The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable.

What changed between base and head:

  • CodSpeed runner v5 changed how benchmarks are measured (base 4.17.7-alpha.2 → head 5.6.3). View release notes

Re-run the base with the same settings to get a valid performance comparison.


Comparing cod-4140-migrate-gen2-macro-runners (d24bcbc) with main (9c93085)

Open in CodSpeed

@not-matthias
not-matthias force-pushed the cod-4140-migrate-gen2-macro-runners branch from 152ef2e to 8cf1950 Compare November 5, 2026 11:44
Switch codspeed-walltime and electron-e2e from codspeed-macro to
codspeed-macro-x64-ryzen-9950x-ubuntu-24-04.
Drop the v4.17.7-alpha.2 pin. Current runner releases still support the
samply walltime profiler.
@not-matthias
not-matthias force-pushed the cod-4140-migrate-gen2-macro-runners branch from 8cf1950 to 6b3f9f7 Compare November 5, 2026 11:45
@not-matthias not-matthias changed the title ci: migrate macro jobs to gen2 x64 runners ci: move macro jobs to the x64 macro runner Nov 5, 2026
@not-matthias
not-matthias marked this pull request as ready for review November 5, 2026 11:48
@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found in the runner changes.

Summary

Moves codspeed-walltime and electron-e2e to codspeed-macro-x64-ryzen-9950x-ubuntu-24-04.

  • Both macro benchmark jobs now run on the named x64 Ryzen runner.
  • The Electron benchmark now requests the latest CodSpeed runner.

not-matthias intentionally removed the Electron runner pin, stating that current runner releases still support samply. The PR description also states that benchmark history starts a new baseline on the new runner.

Reviews (1) · Last reviewed commit: "ci: run electron e2e on the latest runne..." · Reviewed by Greptile

@not-matthias
not-matthias force-pushed the cod-4140-migrate-gen2-macro-runners branch from f93001e to d24bcbc Compare November 5, 2026 13:21
@not-matthias
not-matthias added this pull request to stack #120 November 5, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant