Repository navigation
feat: report the machine's isolation level in the upload metadata - #614
Closed
GuillaumeLagrange wants to merge 1 commit into
Closed
GuillaumeLagrange wants to merge 1 commit into
GuillaumeLagrange wants to merge 1 commit into
Conversation
Read from CODSPEED_RUNNER_ISOLATION, set by the machine running the job. Refs COD-4138
Merging this PR will not alter performance2 warnings
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload metadata now reports the isolation level of the machine running the benchmarks, as
runner.isolation.The machine running the job sets it in
CODSPEED_RUNNER_ISOLATION; CodSpeed Macro Runners set it tostrict, for example. The runner trims the value and leaves the field out when the variable is unset or blank, so uploads from other environments are unchanged.The backend support is not released yet. Until it is, the field is ignored like any other unknown metadata.
Refs COD-4138