Repository navigation
feat(events): member calendar feed and one Add to calendar menu - #260
Merged
Merged
Conversation
A member can subscribe to only the events they RSVP'd to, and the two calendar text links become one menu with Google, Outlook.com and .ics. RSVPs are already public, so the member feed needs no token. Co-Authored-By: Claude Fable 5.2 <[email protected]>
Bridges the calendar spec change to code. Co-Authored-By: Claude Fable 5.2 <[email protected]>
The same 90-day window and VEVENT rules as the site feed, narrowed to the events one member has an RSVP on, under its own calendar name. Unknown or deactivated people answer 404. Co-Authored-By: Claude Fable 5.2 <[email protected]>
One menu replaces the two text links on event detail and appears on full event cards. Signed-in members can subscribe to all events or to only the ones they are going to. Co-Authored-By: Claude Fable 5.2 <[email protected]>
The shared dropdown matches a menu's width to its trigger, so the menu on a card's icon button was 8rem wide and its items wrapped. On a phone the Subscribe menu also sat against the screen edge. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01S8dthiZS2vwh674eh2DDQs
Outlook.com renders the body parameter as HTML, so a < or & in an event description was read as markup. The spec's Outlook row now says so. Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01S8dthiZS2vwh674eh2DDQs
Co-Authored-By: Claude Fable 5.2 <[email protected]> Claude-Session: https://claude.ai/code/session_01S8dthiZS2vwh674eh2DDQs
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Chris Alfano's idea in
#website-relaunch: "ical subscription feed for users, add to calendar button for events."The site-wide
webcal://feed and the per-event Google Calendar and .ics links already existed. This adds the two missing pieces.What changes
GET /api/events/feed.ics?attendee=<slug>is the site feed narrowed to the events one member has an RSVP on, under its own calendar name. Same 90-day window andVEVENTrules. Public with no token, because RSVPs are already public./events. Signed-in members choose "all events" or "events I'm going to", each with awebcal://link and a copy fallback. Signed-out visitors see what they saw before.Specs lead:
specs/behaviors/events.md,specs/api/events.md,specs/screens/event-detail.md,specs/screens/events-index.md. Plan:plans/calendar-member-feed.md.Decisions to review
attendee.Verified
npm run type-check && npm run lint && npm testclean: 624 API tests, 186 web tests, 116 shared tests.Not verified
in-progressand its validation boxes unticked until someone clicks through the menus.fixturebranch ofcodeforphilly-data.🧡🤖 Written by GrittyBot, Code for Philly's ops bot. I am an AI.
🤖 Generated with Claude Code