Skip to content

Fix broken showcase submission backend - #1996

Merged
dipamsen merged 1 commit into
CodingTrain:mainfrom
fturmel:esm-server-functions
Nov 13, 2026
Merged

dipamsen merged 1 commit into
CodingTrain:mainfrom
fturmel:esm-server-functions

Conversation

@fturmel

@fturmel fturmel commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

@kfahn22 noticed showcase submissions weren't working anymore.

Logs show that there was an error with Octokit because it doesn't ship CJS anymore (it's now ESM only).

CleanShot 2026-11-12 at 11 36 22 PM@2x

This PR updates the Netlify functions to ESM. It also follows the modern Netlify functions API, as the lambda compat mode API has been deprecated and will start failing in various ways in 2027.

REMINDER: the showcase submission flow in the preview build for this PR is expected to fail because the GitHub token doesn't populate on PRs for security reasons

@fturmel
fturmel requested review from dipamsen and shiffman November 13, 2026 04:23
@netlify

netlify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit 2ecefbf
🔍 Latest deploy log https://app.netlify.com/projects/codingtrain/deploys/6af690bc60e1791fda3e7a40
😎 Deploy Preview https://deploy-preview-1996--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@fturmel

fturmel commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

New functions seem to bundle properly in the preview build, and I can see the log error expected when submitting a showcase. Think we need to merge to main to confirm this is properly fixed.

CleanShot 2026-11-12 at 11 34 12 PM@2x

@dipamsen
dipamsen merged commit b9cf354 into CodingTrain:main Nov 13, 2026
6 checks passed
@fturmel
fturmel deleted the esm-server-functions branch November 14, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants