Repository navigation
Conversation
Now that we know that only 32-bit platforms require thez bootstrap, and that amd64 never requires it, the code is a lot simplified. Also, this unscatters the bootstrap code: everything is in one place.
illwieckz
force-pushed
the
illwieckz/simplify-bootstrap
branch
2 times, most recently
from
November 10, 2026 01:05
53546af to
e1622d7
Compare
slipher
reviewed
Nov 10, 2026
| // https://github.com/Unvanquished/Unvanquished/issues/944#issuecomment-744454772 | ||
| static void CheckMinAddressSysctlTooLarge() | ||
| { | ||
| #ifdef __linux__ |
Member
There was a problem hiding this comment.
This is Linux-only on purpose - I believe the sysctl names and /proc stuff are specific to the Linux kernel.
Member
Author
There was a problem hiding this comment.
Right, I forgot the freebsd engine can run the linux loader for a bit.
illwieckz
force-pushed
the
illwieckz/simplify-bootstrap
branch
from
November 10, 2026 01:32
e1622d7 to
f2ff3da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we know that only 32-bit platforms require thez bootstrap, and that amd64 never requires it, the code is a lot simplified. Also, this unscatters the bootstrap code: everything is in one place.