Repository navigation
Conversation
load_pixel_response_kernel set the output window to int((Hpy - 1) / bins_per_pix) pixels per axis. For the 45-bin tables at 10 bins per pitch that is 4 pixels, offsets [-2, -1, 0, 1]: the +2 neighbour was never filled, and the response was not mirror-symmetric under a deposit offset u -> -u. Use 2 * (int((Hpy - 1) / bins_per_pix) // 2) + 1 pixels, offsets [-h..h]. The reach on the negative side is unchanged (2 pitches for 45 bins). The furthest lookup, (h + 1/2) pitch, stays inside the table. Callers already index output pixel i as offset i - py_zero_bin, and compute_box_dims derives the box from kernel_py, so no other code changes. Cost: 5x5 instead of 4x4 response entries per deposit (1.56x). Hand-set box_bpy/box_bpz values tuned for the 4-wide kernel (for example, profiler outputs) need +1. Adds tests/test_pixel_kernel_window.py: waveforms at u and -u match under the pixel mirror m -> -m. It fails before this change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_pixel_response_kernel set the output window to int((Hpy - 1) / bins_per_pix) pixels per axis. For the 45-bin tables at 10 bins per pitch that is 4 pixels, offsets [-2, -1, 0, 1]: the +2 neighbour was never filled, and the response was not mirror-symmetric under a deposit offset u -> -u.
Use 2 * (int((Hpy - 1) / bins_per_pix) // 2) + 1 pixels, offsets [-h..h]. The reach on the negative side is unchanged (2 pitches for 45 bins). The furthest lookup, (h + 1/2) pitch, stays inside the table. Callers already index output pixel i as offset i - py_zero_bin, and compute_box_dims derives the box from kernel_py, so no other code changes.
Cost: 5x5 instead of 4x4 response entries per deposit (1.56x). Hand-set box_bpy/box_bpz values tuned for the 4-wide kernel (for example, profiler outputs) need +1.
Adds tests/test_pixel_kernel_window.py: waveforms at u and -u match under the pixel mirror m -> -m. It fails before this change.