Repository navigation
tests: make test_delpay_works deterministic - #9728
Open
daywalker90 wants to merge 1 commit into
Open
daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
The test relied on force-disconnecting l2 from l3 to make the cheap route fail. Whether that failure happened depended on timing: the disable channel_update for l2<->l3 could reach l1 before it computed the route, in which case l1 never tried the cheap route and only one payment was recorded. This was seen as a CI flake. Instead, run l2 with the fail_htlcs plugin so it rejects the forward on purpose. The first attempt always fails and the retry via l4 always succeeds. Also rename the variable that holds the successful payment from `failed` to `success`. Changelog-None Signed-off-by: daywalker90 <[email protected]>
daywalker90
force-pushed
the
tests/delpay-deterministic-failure
branch
from
November 13, 2026 13:15
c5b2457 to
8edd1a0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test relied on force-disconnecting l2 from l3 to make the cheap route fail. Whether that failure happened depended on timing: the disable channel_update for l2<->l3 could reach l1 before it computed the route, in which case l1 never tried the cheap route and only one payment was recorded. This was seen as a CI flake.
Instead, run l2 with the fail_htlcs plugin so it rejects the forward on purpose. The first attempt always fails and the retry via l4 always succeeds.
Also rename the variable that holds the successful payment from
failedtosuccess.Changelog-None
Fixes: #9727