Repository navigation
fix(role): never choose a cordoned standby as the voter that comes in - #239
Merged
Merged
Conversation
The decision program read only the eligibility label when listing standbys that could replace an unfit voter, so a host the operator had cordoned (for instance one under repair) ranked as a candidate. A swap then ends by uncordoning the incoming node, which would return the host to service. Read the node's unschedulable flag, report it per host, and leave a cordoned standby out of the candidates.
|
🎉 This PR is included in version 2.44.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A standby the operator has cordoned is no longer a candidate for an etcd vote. The decision program listed standbys by the eligibility label alone, so a cordoned host (one under repair, say) could rank first, and a swap finishes by uncordoning the node that comes in.
scripts/fleet-role.jqnow readsspec.unschedulablefor each node, reports it ascordonedin the host's status, and skips such a standby when choosing the voter that comes in. A test cordons the only fit standby and expects no swap; with the filter removed it fails.