Skip to content

[CHA-6675] feat: add includeSoftDeletedChannel to getChannel - #283

Merged
nijeesh-stream merged 1 commit into
mainfrom
feature/cha-6675-get-channel-include-soft-deleted
Nov 13, 2026
Merged

nijeesh-stream merged 1 commit into
mainfrom
feature/cha-6675-get-channel-include-soft-deleted

Conversation

@nijeesh-stream

@nijeesh-stream nijeesh-stream commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

  • Problem: Bumble's Trust & Safety team reads channels with Channel.getChannel. A soft-deleted channel returns a 404, so they can't review its messages.
  • Change: adds includeSoftDeletedChannel to the get-channel request. With it set, the backend returns a soft-deleted channel with deletedAt populated, and its messages page as usual.
  • Risk: low. It's a new optional field that's null by default, so existing calls send the same request as before.

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Ticket: https://linear.app/stream/issue/CHA-6675/allow-getchannel-to-optionally-return-soft-deleted-channels
Backend: https://github.com/GetStream/chat/pull/20790

  • GetChannelRequestData gets an include_soft_deleted_channel field. The Lombok builder exposes it as .includeSoftDeletedChannel(Boolean).
  • The backend honours it only on server-side requests. Members of a deleted channel are not returned.
  • The new test creates a channel, sends two messages, and soft-deletes the channel. It checks that a plain getChannel still returns a 404, and that includeSoftDeletedChannel(true) returns the channel with deletedAt set and both messages.

Merge order

This SDK's tests run against the live CI app. The new test will fail until chat#20790 is released and deployed to that app's shard. Merge the backend first, then re-run CI here.

🤖 Generated with Claude Code


Note

Low Risk
Optional request field defaults to unset, so existing getChannel calls are unchanged; behavior depends on the paired backend release.

Overview
Adds an optional includeSoftDeletedChannel flag on Channel.getChannel request data (serialized as include_soft_deleted_channel). When set, callers can fetch a soft-deleted channel and page its messages instead of getting a 404; the response includes deletedAt, and members are not returned (per backend behavior documented in Javadoc).

A new integration test covers create → message → soft-delete → 404 without the flag → success with includeSoftDeletedChannel(true) and both message IDs.

Reviewed by Cursor Bugbot for commit c7c3fd8. Bugbot is set up for automated code reviews on this repo. Configure here.

@nijeesh-stream
nijeesh-stream marked this pull request as ready for review November 13, 2026 11:00
@nijeesh-stream
nijeesh-stream merged commit d797459 into main Nov 13, 2026
5 of 6 checks passed
@nijeesh-stream
nijeesh-stream deleted the feature/cha-6675-get-channel-include-soft-deleted branch November 13, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants