Repository navigation
[CHA-6675] feat: add includeSoftDeletedChannel to getChannel - #283
Merged
nijeesh-stream merged 1 commit intoNov 13, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
nijeesh-stream
marked this pull request as ready for review
November 13, 2026 11:00
ianb-gs
approved these changes
Nov 13, 2026
nijeesh-stream
deleted the
feature/cha-6675-get-channel-include-soft-deleted
branch
November 13, 2026 11:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Channel.getChannel. A soft-deleted channel returns a 404, so they can't review its messages.includeSoftDeletedChannelto the get-channel request. With it set, the backend returns a soft-deleted channel withdeletedAtpopulated, and its messages page as usual.CLA
Description of the pull request
Ticket: https://linear.app/stream/issue/CHA-6675/allow-getchannel-to-optionally-return-soft-deleted-channels
Backend: https://github.com/GetStream/chat/pull/20790
GetChannelRequestDatagets aninclude_soft_deleted_channelfield. The Lombok builder exposes it as.includeSoftDeletedChannel(Boolean).getChannelstill returns a 404, and thatincludeSoftDeletedChannel(true)returns the channel withdeletedAtset and both messages.Merge order
This SDK's tests run against the live CI app. The new test will fail until chat#20790 is released and deployed to that app's shard. Merge the backend first, then re-run CI here.
🤖 Generated with Claude Code
Note
Low Risk
Optional request field defaults to unset, so existing getChannel calls are unchanged; behavior depends on the paired backend release.
Overview
Adds an optional
includeSoftDeletedChannelflag onChannel.getChannelrequest data (serialized asinclude_soft_deleted_channel). When set, callers can fetch a soft-deleted channel and page its messages instead of getting a 404; the response includesdeletedAt, and members are not returned (per backend behavior documented in Javadoc).A new integration test covers create → message → soft-delete → 404 without the flag → success with
includeSoftDeletedChannel(true)and both message IDs.Reviewed by Cursor Bugbot for commit c7c3fd8. Bugbot is set up for automated code reviews on this repo. Configure here.