Repository navigation
ci: read the API key from an Actions variable - #284
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Stream API key is an identifier, yet CI reads it from a repository secret. A secret cannot be read back, so nobody can see which test app CI runs against.
Solution
The workflows read the key from the
STREAM_KEYActions variable. The API secret stays a repository secret.STREAM_MULTI_TENANT_KEYreads its variable first and falls back to the secret until the variable is created.How to verify
STREAM_KEYrepository secret is deleted.Note
Low Risk
Workflow-only change that moves a non-secret API key to variables; secrets still gate credentials, with a migration fallback for multi-tenant keys.
Overview
CI, release, and scheduled test workflows now supply
STREAM_KEYfrom the GitHub Actionsvars.STREAM_KEYrepository variable instead ofsecrets.STREAM_KEY, so the test app identifier is visible whileSTREAM_SECRETstays secret.In
ci.yml,STREAM_MULTI_TENANT_KEYprefersvars.STREAM_MULTI_TENANT_KEYand falls back to the existing secret until that variable exists.release.ymlapplies the same variable-basedSTREAM_KEYfor Stream repo staging and Maven Central publish steps.Reviewed by Cursor Bugbot for commit 0701619. Bugbot is set up for automated code reviews on this repo. Configure here.