Repository navigation
chore(ci): port the App Store Connect key, bot token and sample distribution changes from develop - #3993
Merged
Conversation
…ibution changes from develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Bring the CI changes from
developtov9-release, so its release and sample distribution workflows work with the current secrets and variables.Ports #3990, #3991 and #3992.
Ticket: https://linear.app/stream/issue/RN-529
🛠 Implementation details
examples/SampleApp/fastlane/Fastfile: theappstore_api_keylane uses key ID8KCMZF773S(chore(ci): update the App Store Connect API key and drop the S3 sample APK upload #3990).sample-distribution.yml:MATCH_GIT_BASIC_AUTHORIZATION.matchclones over SSH (chore(ci): update the App Store Connect API key and drop the S3 sample APK upload #3990).ANDROID_FIREBASE_APP_IDis read from the repository variable instead of a secret (chore(ci): read the Android Firebase app ID from a repository variable #3991).release.yml: usesCI_BOT_GITHUB_TOKENinstead ofSTREAM_CI_GITHUB_BOT_TOKEN(chore(ci): use CI_BOT_GITHUB_TOKEN for releases #3992).Applied to the
v9-releaseversions of the files, so nothing else fromdevelopcomes along.🎨 UI Changes
None.
🧪 Testing
CI only. The next release run on
v9-releaseshould push and publish as before.☑️ Checklist
developbranch (targetsv9-releaseon purpose)