You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(ci): run releases in the npm-release environment - #3443
npm trusted publishing checks the repository and the workflow file name, not the branch. Today anyone with write access could push a branch with their own release.yml, start it, and publish to npm.
This PR runs the release job in the npm-release environment. The environment already exists and is set up as follows:
Branches: master and release-v* only.
Required reviewers: oliverlaz, NikolaGoranNaumovski, MartinCupela, with self-review blocked.
What changes for releases
Every release run waits for one of the reviewers to approve it. Whoever starts the run can't approve it themselves.
Dry runs also go through the environment. They have to start from master or release-v* and need approval too. A run from any other branch fails before it starts.
After merge
On npmjs.com, set Settings → Trusted Publisher → Environment to npm-release for stream-chat-react. From then on npm rejects OIDC tokens from runs outside the environment. Do this only after the same change is merged on every releasing branch (master, release-v9 to release-v14), or releases from a branch without it fail.
The release job runs in the npm-release environment, which only master
and release-v* may use and which needs a reviewer's approval. Once the
npm trusted publisher requires this environment, a release.yml run from
any other branch can no longer publish.
No actionable comments were generated in the recent review.
Walkthrough
The package_release job in the release workflow now declares the npm-release environment. A comment describes the environment’s branch restriction and trusted-publisher requirement. The existing branch condition is unchanged.
This moves the release job into the npm-release environment, so releases and dry runs now need approval and can only run from master or release-v*. The environment is already configured this way, and no remaining merge-blocking risk was found. Update npm's Trusted Publisher setting only after the release-v14 PR also merges, as the description notes.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the change: the release job now runs in the npm-release environment. It uses the conventional commit prefix 'chore(ci)', and the diff touches only the release workflow, so the title ma…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description explains the goal (npm trusted publishing checks only repository and workflow file name, so any writer could publish via a branch with its own release.yml). It also describes the imple…
Full details: Title check
Explanation
The title names the change: the release job now runs in the npm-release environment. It uses the conventional commit prefix 'chore(ci)', and the diff touches only the release workflow, so the title matches the changeset.
Full details: Description check
Explanation
The description explains the goal (npm trusted publishing checks only repository and workflow file name, so any writer could publish via a branch with its own release.yml). It also describes the implementation (release job runs in the npm-release environment with branch and reviewer restrictions), the behavior change for releases and dry runs, and post-merge steps. It does not follow the template's headings, and the UI Changes section is absent. That section does not apply to this CI-only change, so the omission is acceptable. Overall the description is mostly complete.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 6030a662-7202-4545-80ed-e7bf1d1d425b
Commits
Reviewing files that changed from the base of the PR and between e47b2a6 and 7581345.
Files selected for processing: 1
.github/workflows/release.yml
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm trusted publishing checks the repository and the workflow file name, not the branch. Today anyone with write access could push a branch with their own
release.yml, start it, and publish to npm.This PR runs the release job in the
npm-releaseenvironment. The environment already exists and is set up as follows:masterandrelease-v*only.What changes for releases
masterorrelease-v*and need approval too. A run from any other branch fails before it starts.After merge
On npmjs.com, set Settings → Trusted Publisher → Environment to
npm-releaseforstream-chat-react. From then on npm rejects OIDC tokens from runs outside the environment. Do this only after the same change is merged on every releasing branch (master,release-v9torelease-v14), or releases from a branch without it fail.