Repository navigation
test(SDK-615): inbox message display URL handling - #940
Conversation
Align reserved iterable:// handling so unknown schemes do not reach urlHandler; only delete and dismiss run SDK actions.
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
Drop the file-local jest.mock so we use jest.setup’s View stub; find the WebView node by View type + onMessage.
|
Product note — unknown The behavior where we still call
So the most consistent product answer is: keep click/close tracking for reserved-but-unknown |
Comment why trackInAppClick/Close run before unknown iterable:// handling.
rtlsilva
left a comment
There was a problem hiding this comment.
Requesting changes, plus one additional PR-level comment:
The body says "SDK-633 alignment", but this PR ships only SDK-633 item 3 (inbox parity). Suggest saying that SDK-633 stays open for:
- the example:
example/src/hooks/useIterableApp.tsx:197still setsallowedProtocols = ['app', 'iterable'], and itsurlHandler(lines 178–189) still treats these links as navigation. After this PR, example inbox links that useiterable://stop navigating. - docs saying
iterable://is reserved fordelete/dismiss(SDK-633 AC1). None exist yet. - SDK-633 AC3 and AC5.
Align with native HTML in-apps; strengthen tests and changelog per review.
rtlsilva
left a comment
There was a problem hiding this comment.
Approved with minor wording suggestions. LGTM
Per review: http(s) uses Linking not urlHandler in inbox; comment describes outcome without claiming cross-platform track order.

📝 Summary
Adds Jest coverage for
IterableInboxMessageDisplaylink routing and fixes reservediterable://handling so unknown paths close the message without callingurlHandlerorcustomActionHandler.🎟️ Jira Ticket: SDK-615
📖 Description
IterableInboxMessageDisplay.test.tsxexercises WebViewonMessageflows: https,iterable://delete/dismiss,action://, unknowniterable://, custom scheme →urlHandler, andtrackInAppClick/trackInAppClose.iterable://(other than delete/dismiss) now callsreturnToInbox()after tracking, matching native HTML in-apps (SDK-633 inbox item 3 only).SDK-633 follow-ups (not this PR)
example/src/hooks/useIterableApp.tsxstill allowsiterable://inurlHandler/allowedProtocols— may need a separate change after this ships.iterable://for delete/dismiss (AC1).🧪 How to test?
yarn test src/inbox/components/IterableInboxMessageDisplay.test.tsxyarn lint && yarn typecheck && yarn test --coverage && yarn check:circular🧾 Changelog
Unreleased Fixes bullet for inbox
iterable://handling (no test-only changelog line).📹 Loom recording if applicable
N/A
🐞 Github Issues solved
N/A