Repository navigation
fix(SDK-635): handle app:// deep links in the Android example - #943
Open
jferrao-itrbl wants to merge 1 commit into
Open
jferrao-itrbl wants to merge 1 commit into
jferrao-itrbl wants to merge 1 commit into
Conversation
Declare a VIEW/BROWSABLE intent-filter and a queries entry for the app scheme. Navigate from urlHandler through a navigation ref and return false when logged out. Document the adb steps in the example README.
|
|
Coverage Impact This PR will not change total coverage. Commit bb3f2de · 🚦 See full report on Qlty Cloud »🛟 Help
|
1 new issue
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Example Android app now handles
app://deep links: manifest filter, navigation ref, logged-out guard, adb docs.🎟️ Jira Ticket: SDK-635
📖 Description
An Open URL push with
app://inboxdid not open the example app and navigate on Android. Changes (example app only, nosrc/or bridge changes):AndroidManifest.xml: VIEW/DEFAULT/BROWSABLE intent-filter for theappscheme onMainActivity, plus a matching<queries>entry (needed forLinking.canOpenURLon Android 11+ whenurlHandlerreturns false).urlHandlernavigates through anavigationRefonNavigationContainerinstead of the Login screen'snavigationprop, which is stale after login.initialize()no longer takesnavigation.urlHandlerruns and returnsfalse; the URL is not deferred.example/README.md: "Testing deep links (Android)" with the adb command and push scenarios.Scope:
appscheme only (iterable://is SDK-638), Android only, no embedded route added. In the example,urlHandleris registered only after Sign in, so a cold-start push reaches it once the user has signed in.🧪 How to test?
Sign in first. Then send an Open URL push with
app://inboxwith the app killed and in the foreground; the Inbox tab should show. Alinks.iterable.comlink wrapping anapp://URL is expected to reachurlHandlerunwrapped (native SDK behaviour, not verified here).Not verified: the Android build step (
yarn turbo run build:android) was waived because of a local environment problem (Gradle autolinking resolves a path outside the checkout), so the manifest change is not build-verified and nothing was run on a device.yarn lint,yarn typecheckandyarn test --coveragepass.🧾 Changelog
No customer facing changes
📹 Loom recording if applicable
N/A
🐞 Github Issues solved
None
📚 Docs PR if applicable
N/A