Repository navigation
Reexport NML headers - #4852
Reexport NML headers#4852BsAtHome wants to merge 2 commits into
Conversation
|
tests/build/ui/nml-position-logger.cc and tests/interp/compile/use-rs274.cc still include |
|
Yes, I had a feeling I missed something. The install needs to be fixed for the dev package and the tests should also be using the include directory properly. |
3e67b3d to
a42466e
Compare
|
Right, now the headers are installed by tree copy. The |
|
I think dropping the interpreters access to hal is a bad idea, it is really useful when programming toolchangers. going thru motion IO pins is cumbersome, especially if you have a lot of IO. it is also self documenting if you have the name in the code, instead of a number. A better way of doing it would be to do the ini and hal access thru a canon command(e.g. READ_SPECIAL_VARIABLE(name)), this would remove the linkage. Important difference here: the hal access is read at readahead time, while motion IO is synced to what is actually executed. |
This PR reexports the NML headers. It does so by putting them in the
include/libnml/...andinclude/nml_intf/hierarchies. If someone needs it to be flattened, then they can simply add the appropriate-Ioptions to their private compile job (we got rid of most of them for good reason).The reexport also fixes collision prone double inclusion protection by using a proper prefix. All the
#includedirectives have been updated to use the proper<>style for the moved includes, unless an include file target is local to the directory of the file being compiled (and that also goes for includes including includes).This PR should fix some of the problems of #4774. There are many more changes and fixes to the NML stuff between 2.9 and master. Any use needs very, very careful attention if you try to interface using the binary interface and try to port 2.9 code to master and future 2.10.