Repository navigation
Drop the untested data-length suggestion from the MTU advice - #34
Merged
Merged
Conversation
LE Write Suggested Default Data Length was offered for a 4.2+ radio that still negotiates an ATT MTU of 185, which nobody has run into. The one Pi 4 that reported a radio older than its board was missing BCM4345C0.hcd, and installing the firmware is what fixed it. Point the runtime error at the firmware note instead, and leave the dongle and -transport impossible as the advice that has actually worked.
ps2
marked this pull request as ready for review
November 13, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MTU troubleshooting section, and the error the simulator prints when the link is too
small, both suggested:
That was written for a 4.2+ radio that still negotiates an ATT MTU of 185. Nobody has
reported that case. The one Pi 4 that reported a radio older than its board turned out to
be missing
BCM4345C0.hcd; installing the firmware moved it from 4.1/Broadcom to5.0/Cypress and the pairing went through. The command itself was never run against a
failing pairing, so we don't know that it changes a negotiated MTU.
A runtime error is the wrong place for a guess, so this removes it from both places. The
error now points at the firmware note in the README, which is what actually fixed the one
real case, and the dongle and
-transport impossibleremain as the advice that hasworked.
go build ./...,go vet ./pkg/bluetooth/andgo test ./...are green (all packagespass, unchanged from main).