Repository navigation
Conversation
- Add a preset-driven Visual Studio CMake matrix alongside MSBuild and Ninja parity. - Upload CTest reports and Release artifacts; include CMake inputs in vcpkg cache keys. - Resolve MIDL from the selected Windows SDK and document the Visual Studio Open Folder workflow. - Refresh build memory for the CMake and CI transition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Local CLI validation covers only x64 Debug, leaving the Windows CI matrix, Release/Win32 builds, and interactive Visual Studio Open Folder target and test discovery unverified.
No open issues 🎉
What changed in this PR
Advances Phase 5 of the CMake migration, building on #65 by adding Visual Studio CMake CI coverage while retaining MSBuild validation and Ninja parity checks.
Changes:
- Adds a Visual Studio CMake build/test matrix, test-report and Release artifact uploads, and CMake-aware cache keys.
- Adds MIDL lookup hints using the Windows SDK selected by CMake.
- Documents Visual Studio Open Folder usage and updates build memory to reflect CMake integration.
| File | Description |
|---|---|
README.md |
Adds CMake prerequisites and introduces Visual Studio Open Folder usage. |
docs/BUILDING.md |
Explains generator requirements, Open Folder usage, and separate build outputs. |
cmake/MwgMidl.cmake |
Adds MIDL search paths for the selected Windows SDK. |
.github/workflows/build.yml |
Adds Visual Studio CMake CI and artifact uploads while retaining existing checks. |
.ai/memory/build/windows.md |
Updates the documented CI matrix and platform requirements. |
.ai/memory/build/README.md |
Updates the CMake memory index description. |
.ai/memory/build/cmake.md |
Replaces outdated build status with CMake presets and CI integration details. |
Review effort: Balanced
Julian-MW
reviewed
Nov 12, 2026
Julian-MW
left a comment
Julian-MW
left a comment
There was a problem hiding this comment.
Automated review. Final decision is with the human reviewer.
- Respect an SDK selected by generated Visual Studio projects. - Test legacy SDK defaults, overrides, and generated project selection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Keep the CMake parity check name distinct from the Visual Studio matrix. - Warn when CTest report artifacts are missing. - Document CMake prerequisites and the conditional sample target. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5 of the CMake migration, stacked on #65.
Local validation passed for CMake Visual Studio x64 Debug configure/build/CTest and the Debug x64 MSBuild build and tests. GitHub Actions and interactive Visual Studio checks remain pending.