Skip to content

chore: upgrade Node.js to 24.22.3 for November 2026 security release - #264

Merged
Alessandro100 merged 2 commits into
mainfrom
chore/node-24.22.3
Nov 12, 2026
Merged

Alessandro100 merged 2 commits into
mainfrom
chore/node-24.22.3

Conversation

@Alessandro100

@Alessandro100 Alessandro100 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Bumps the Node.js version used by CI and deploy workflows from 24.12.0 to 24.22.3, the patched 24.x release from the November 2026 Node.js security release (published 2026-11-10). 24.22.3 also includes the October 2026 fixes (24.22.1) originally tracked in #258.

  • .github/workflows/preview-pr.yml: NODE_VERSION 24.12.0 -> 24.22.3
  • .github/workflows/vercel-prod-on-release.yml: NODE_VERSION 24.12.0 -> 24.22.3 (this also rotates the Next build cache key, which embeds the Node version)
  • New .nvmrc (24.22.3) so nvm use gives local dev the same version as CI
  • src/instrumentation.ts logs Node.js runtime <process.version> once per server instance start, so the production runtime version can be confirmed in Vercel logs

package.json engines.node stays 24.x: Vercel only reads the major version from it and picks the patch itself.

Why

The November release fixes 16 flaws (7 high) in HTTP/2, HTTPS and TLS, including HTTP/2 server crashes and memory leaks, an HTTPS memory disclosure that can expose TLS private keys, and TLS SNI and renegotiation issues. Next.js serves over plain node:http behind Vercel's edge, so direct exposure is low, but we were two security releases behind.

Advisory: https://nodejs.org/en/blog/vulnerability/november-2026-security-releases

Verification (local, Node v24.22.3)

  • yarn lint: 0 errors (3 existing warnings, none in files this PR touches)
  • yarn test:ci: 45/45 suites, 602/602 tests passed
  • npx tsc --noEmit: clean
  • yarn build:prod: succeeded

Not covered by this PR

  • Confirm the Node patch version Vercel uses for production functions is >= 24.22.3: after release, search the deployment's runtime logs for Node.js runtime (or check Sentry's Runtime context). We cannot pin this from the repo.
  • Team members update local Node: nvm install && nvm use in the repo root.

Refs #258

🤖 Generated with Claude Code

Bump the CI/deploy Node pin from 24.12.0 to 24.22.3, which includes the
October 2026 (24.22.1) and November 2026 (24.22.3) security fixes for
HTTP/2, HTTPS, TLS, zlib and dns. Add .nvmrc so local dev matches CI.

Refs #258

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
mobilitydatabase-web Ready Ready Preview Nov 12, 2026 7:04pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

*Lighthouse ran on https://mobilitydatabase-5gwmur6ta-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 60 🟢 90 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-5gwmur6ta-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 87 🟠 87 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-5gwmur6ta-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🔴 36 🟢 95 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-5gwmur6ta-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 99 🟠 84 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-5gwmur6ta-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 72 🟢 94 🟢 96 🟢 100

Vercel picks the Node patch version for functions, so log
process.version once per instance start to confirm the runtime in
production logs.

Refs #258

Co-Authored-By: Claude Opus 5.5 <[email protected]>

@davidgamez davidgamez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only one minor feedback

Comment thread src/instrumentation.ts
if (process.env.NEXT_RUNTIME === 'nodejs') {
// Log the runtime Node version once per instance start. Vercel picks the
// patch version itself, so this is how we confirm it in production logs.
console.info(`Node.js runtime ${process.version}`);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion]: The instrumentation.ts log isn't needed for the upgrade. Sentry already reports the Node version in the Runtime context of every server event, and this would log on every cold start. Could we drop it and check Sentry after the release instead?

@Alessandro100
Alessandro100 merged commit e58d6a9 into main Nov 12, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
Preview — 14c9bd63 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants