Repository navigation
Conversation
|
There was a problem hiding this comment.
Great idea for improving local dev workflow 👍
Before merging, I'd like to request a few adjustments/additions though, to make this new option more visible for future developers:
- Please add a comment to the README informing future new contributors that they can also use an
.envfile instead of exporting theirGITHUB_TOKENas an env var. - Please check-in a default
.envwith a dummy token
Also, please remove package-lock.json, we're using yarn, not npm for building, so yarn.lock should be sufficient. Might make sense to add it to .gitignore.
| plugins/source-terasology-modules/data.json | ||
| plugins/source-terasology-engine/data.json | ||
|
|
||
| .env No newline at end of file |
|
Closing: the site moved from Gatsby to Astro in #263, so gatsby-config.js and yarn.lock no longer exist and the branch can't be merged. Thanks for the work. Issue #238 stays open; the new data loaders read GITHUB_TOKEN from the environment, so a .env option would need a fresh change against the Astro setup. |




Fixes #238