Repository navigation
[20.0][IMP] update dotfiles - #1030
Open
carlosdauden wants to merge 2 commits into
Open
carlosdauden wants to merge 2 commits into
carlosdauden wants to merge 2 commits into
Conversation
Update the oca-addons-repo-template to v1.48. The main effect on 20.0 is that ruff ignores RUF012 (mutable-class-default), like Odoo core does, so `_inherit` lists pass ruff 0.16 without `# noqa`. It also pins the GitHub actions to recent versions and adds a checklog-odoo ignore for the bootstrap color warning when html_editor is not installed.
Remove the `# noqa: RUF012` comments, now unused (RUF100) because the template v1.48 ignores RUF012 on 20.0.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the 20.0 branch to oca-addons-repo-template v1.48 (
copier update --vcs-ref=v1.48).The main effect on 20.0 is OCA/oca-addons-repo-template#376: ruff ignores RUF012 (mutable-class-default) for Odoo >= 20.0, as Odoo core does in its ruff.toml. The pre-commit rev of ruff (0.16.8) enables RUF012 by default, so with v1.45 every
_inherit = ["a", "b"]in a migrated module fails pre-commit unless it carries# noqa: RUF012. With this update lists keep passing, as in Odoo core.Other template changes since v1.45: GitHub workflows hardened and actions pinned to recent versions (OCA/oca-addons-repo-template#374), and a checklog-odoo ignore for a bootstrap warning when html_editor is not installed (OCA/oca-addons-repo-template#378).
Same update as OCA/server-tools#3836 (renovate).
A second commit removes the two
# noqa: RUF012comments that become unused (RUF100) with this update;ruff check --fixin pre-commit removes them automatically.ping @sergio-teruel @carlos-lopez-tecnativa @juancarlosonate-tecnativa