Repository navigation
Conversation
The runtime option openapiGeneratorIgnoreList works but was missing from apps/generator-cli/src/config.schema.json, so editors flag configs using it as invalid (Fixes OpenAPITools#1138). The option is typed as Set<String> upstream in openapi-generator's GeneratorSettings/CodegenConfigurator and pre-populates the .openapi-generator-ignore file, so the new property accepts an array of strings; a comma separated list is accepted as well, mirroring the --openapi-generator-ignore-list CLI flag. Adds ajv-based tests validating the schema itself and configs using the new option.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
buildCommand rendered array values through Object.entries, producing indexed assignments such as 0=README.md,1=pom.xml, so array configs like openapiGeneratorIgnoreList never reached the generator as the intended list. Array values are now joined with ',', matching the csv semantics of flags such as --openapi-generator-ignore-list; string and plain object values keep their existing serialization.
|
🎉 This PR is included in version 2.42.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1138
As requested by @wing328 in the issue thread, this PR adds the missing
openapiGeneratorIgnoreListoption toapps/generator-cli/src/config.schema.json.What was done
openapiGeneratorIgnoreListto thegeneratordefinition in the config schema. Configs using the option (as the reporter does) no longer fail schema validation in editors.Set<String>inGeneratorSettings/CodegenConfigurator). A comma separated list is accepted as well, mirroring the--openapi-generator-ignore-listCLI flag.ajv-based tests inapps/generator-cli/src/config.schema.spec.tsthat validate the schema itself and configs using the new option (arrays, comma separated lists, and invalid values).Validation
nx test generator-cli: 7 suites, 247 tests passed (12 of them the new schema tests)nx lint generator-cli: passesSummary by cubic
Adds the missing
openapiGeneratorIgnoreListoption to the generator CLI config schema and fixes how the CLI serializes array config values.--openapi-generator-ignore-listCLI flag, so configs using it no longer fail schema validation in editors.buildCommandnow joins array values with commas instead of rendering them as indexed entries, so the option never reached the generator as the intended list.ajv-based schema tests and generator command tests for the option's accepted and rejected values.Written for commit 1fc35a7. Summary will update on new commits.