Repository navigation
Add the Google Cloud Pub/Sub transport - #6088
Draft
andreasohlund wants to merge 1 commit into
Draft
andreasohlund wants to merge 1 commit into
andreasohlund wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Google Cloud Pub/Sub as a transport for the primary, audit, and monitoring instances, using
NServiceBus.Transport.GooglePubSub.Not ready to merge:
0.0.0-alpha.0.40, which is not on any feed yet, so CI cannot restore. The transport needs a prerelease on feedz for CI, and1.0.0on nuget.org before this merges.GooglePubSubCI category needs theGCP_WORKLOAD_IDENTITY_PROVIDER,GCP_SERVICE_ACCOUNT, andGOOGLE_CLOUD_PROJECTrepository variables, and a service account withroles/pubsub.editor.Behavior
ProjectId,ResourceNamePrefix, andServiceEndpoint, all optional, and rejects any other key. Credentials come only from Application Default Credentials, because ServiceControl creates its ingestion, retry, and throughput receivers without a service provider.ReceiveOnly, the strongest mode the transport supports.Microsoft.Bcl.AsyncInterfaces,Newtonsoft.Json, andSystem.CodeDomare now pinned, because the transport brought in versions thatDuplicateAssembliesInDeploymentUnitsShouldHaveMatchingVersionsrejected. The RavenDB persister moves from Newtonsoft.Json 13.0.3 to 13.0.4.Verification
ServiceControl.Transports.GooglePubSub.Testspasses against the Pub/Sub emulator (17 tests). It has not run against a Google Cloud project.Docs
docs/google-pubsub-transport.mdand linked it fromdocs/README.md.docs/testing.mdwith the CI setup and local emulator steps,docs/usage-report.mdwith the new key and the settings left out, and the test filter list inREADME.md.docs/packaging.mdanddocs/throughput-collection.mdneed no change.servicecontrol/transports.mdonce the transport has its own pages.