[vaisest]

Description of the problem being solved:

This PR rips out the PoE1 mirage and trigger code, and replaces it with a basic implementation that allows for calculating trigger DPS. Mirages are still unsupported. Invocations were not considered here.

Currently, this has configurations for:

• Cast on Crit
• Cast on Melee hit (Thundergod and Smith of Kitava)
• Cast on Block
• Cast on Charm Use (this one is just basically config rate)

Feedback is very welcome. This is not a very full implementation and this is still missing support for some very obvious things like Energy Retention.

This does however seem to work alright. Though there are performance problems with cast on crit due to it rebuilding every skill in power reports. It might be a better idea to just build the previously used skill? The trigger sources are cached similar to PoB1.

Some of the other triggers also seem like they might be tricky. For example, Cast on Ignite and Elemental Ailment. These two also interact with some of the fake hit spells, which PoB doesn't seem to handle in any different way to regular hits at all.

One notable unsupported thing is the active_skill_energy_generated_+%_final stat. I think all of the skills having this are actually using fake hits, which means coc would work with them and would be very wrong. These need to have fake hits handled somehow when the ailment triggers are added.

Steps taken to verify a working solution:

• Verified against wiki information (some of which had info clarified by LocalIdentity recently)
• Automated tests added
• Tested with builds from ninja

Link to a build that showcases this PR:

https://poe.ninja/poe2/pob/2bf20 coc

https://poe.ninja/poe2/pob/2bf22 cod (note that EF is not properly supported here)

Before screenshot:

N/A

After screenshot: