Repository navigation
Conversation
Apply increased Iron Flask effect to its buffs and effective flask stats. Keep generic flask effect additive and other flask bases unchanged.
Keep behavioral flask coverage while consolidating parser cases and dropping implementation-shape checks.
Use the canonical 3.30 exported wording in the recovery tests.
Assert recovery amount and relative duration independently of tooltip colors and current base values. Cover both Diamond multipliers and remove redundant parser-only cases.
Use one local build and tooltip setup while preserving the recovery and utility fixtures and their behavioral assertions.
Active flasks supply the condition. The instant recovery assertions do not depend on it.
Remove tooltip construction and text assertions while retaining the numerical flask checks. Presentation and instant recovery remain part of focused UI verification before publication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supports the flask changes in the 3.30 patch notes:
Legacy wording remains supported. The 3.30 skill trees are handled separately; generated passive data is unchanged here.
Steps to reproduce
Use Split Arrow, active normal Iron and Divine Life Flasks, and an equipped but inactive Diamond Flask. Add these custom modifiers:
Same synthetic build before and after:
Risks/notes
The That Which Was Taken test in
TestRareLike_spec.luaalso fails on the unchanged base.