Repository navigation
Add support for many Wickerman Viscera modifiers - #10451
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for many Wickerman modifiers that were either unrecognized or weren't affecting calculations. Skipped adding many modifiers that don't meaningfully get used in build calcs like
-# Physical Damage taken from Hits by Animals. Can provide a full list of the mods I excluded if needed.Curses granted by wearing a # of influenced items will create an enabled skill. Works with equipped items or as a custom modifier. This works with multi-word curse names like
Assassin's Mark.New or corrected modifier support:
#% of Physical Damage over Time taken as Chaos Damage#% reduced Burning Damage takenCurse Enemies with <Curse Name> on Hit if # <Influence> Items are EquippedMinions created Recently have OnslaughtMinions deal #% increased Damage if you've Hit RecentlyMinions have #% increased Movement Speed if you've used a Minion Skill Recently#% chance to Hinder Enemies on Hit with SpellsImmune to Hinder#% Global chance to Blind Enemies on Hit#% increased Damage while BlindEnemies you Blind while in Sand Stance take #% increased Damage#% increased Life Recovery rate per #% missing Unreserved LifeSkills fire an additional Projectile if you've been Hit RecentlySkills fire an additional Projectile if you've used a Movement Skill RecentlySkills that Cost Life have #% chance to deal Double DamageHits have #% chance to treat Enemy Monster Cold Resistance values as invertedHits have #% chance to treat Enemy Monster Fire Resistance values as invertedHits have #% chance to treat Enemy Monster Lightning Resistance values as invertedDamaging Ailments inflicted by Minions deal damage #% FasterMelee Critical Strikes Poison the Enemy+# to number of Sacred Wisps SummonedOfferings you create also grant #% increased DamageIron Flasks applied to you have #% increased Effect#% increased Evasion Rating from Equipped Helmet, Body Armour Gloves and Boots#% increased Armour from Equipped Helmet, Body Armour, Gloves, and Boots#% increased bonuses gained from Equipped Gloves#% increased bonuses gained from Equipped Boots#% reduced bonuses gained from Equipped Boots+#% to Maximum Effect of ChillYou and Allies within # metres deal # to # additional Cold DamageSkills socketed in Equipped Boots have #% increased Mana Cost EfficiencyIncreases and Reductions to Light Radius also apply to Life Regeneration Rate at #% valueIncreases and Reductions to Mana Regeneration Rate also apply to Energy Shield Recharge Rate at #% of their valueEnemies within # metres are ScorchedSupport details:
You and Allies within # metres deal # to # additional Cold Damagedoesn't check for distance, it just assumes the flat damage bonus.Enemies within # metres are Scorchedjust assumes the distance check succeeds and applies the 10% base effect of Scorch.Steps taken to verify a working solution: