Repository navigation
Conversation
Author
|
I know this is a big PR. but this should not touch to much of the base files just add new functionallity. And im using the official data from GGG for the tree. there's also instructions on how to maintain it upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Players plan their atlas passive tree on separate websites today. This adds an Atlas tab (next to Party and Compare) for planning atlas trees inside Path of Building:
AtlasTrees.xmlnext toSettings.xmland shown in every build, like the in-game atlas, which belongs to the account rather than a character. Changes save automatically.Build calculations are untouched. No calc, mod parsing or passive tree code is changed, atlas stats are never parsed into modifiers, and atlas edits never trigger a recalculation or mark the build as unsaved. Build files are not modified.
Changes to existing files:
Build.lua: the button, the tab, the draw call, and a load-only<Atlas>section for build files from an earlier version of this feature. Saving with the Atlas tab open storesviewMode="TREE".Main.lua: the atlas version list and a cachedmain:LoadAtlasTree.Adding new leagues: run
python3 src/Export/Atlas/import_atlas_tree.py --tag <tag>and commit the result. The steps are indocs/atlas/importing-atlas-versions.md, anddocs/atlas/README.mdexplains how the feature works. Images shared between leagues are stored once (src/TreeData/Atlas/Images/), so all 23 versions together add about 43 MB.Steps taken to verify a working solution:
spec/System/TestAtlas*_spec.lua) cover:TestAtlasNonInterference_spec.lualoads every bundled test build with and without atlas data, allocates atlas nodes, and checks that every calculated output is identical and no recalculation is triggered.TestRareLike_spec.lua, which fails the same way ondevwithout this change.REGENERATE_MOD_CACHE=1) gives no diff.Link to a build that showcases this PR:
Not build-specific: open any build and click Atlas.
Before screenshot:
No Atlas button in the sidebar (new feature).
After screenshot: