Repository navigation
Exclude ES from EHP and Maximum Hit Taken when a self degen keeps ES at 0 - #10457
Open
PersiaDark wants to merge 2 commits into
Open
PersiaDark wants to merge 2 commits into
PersiaDark wants to merge 2 commits into
Conversation
Righteous Fire and other self-inflicted degens are taken from energy shield before life. When energy shield regeneration is lower than the part of the degen that hits energy shield, energy shield sits at 0 while the degen is active, so it can't absorb hits. Treat it as depleted for the hit pools (EHP, max hit taken) the same way Recoverable ES is capped, respecting ES bypass and Eldritch Battery, with a config option to turn it off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10456 .
Description of the problem being solved:
Self degens such as Righteous Fire are taken from energy shield (ES) before life. When ES regeneration is lower than the part of the degen that reaches ES, ES drains to 0 and stays there while the degen is active. PoB still added full ES to every hit pool, so EHP and Maximum Hit Taken were too high for RF builds with any ES. With no ES regeneration, Net Life Regen already left ES out and took the whole degen from life, so it disagreed with EHP.
Changes (CalcDefence
buildDefenceEstimations, plus ConfigOptions and CalcSections):<type>BuildDegen/TotalBuildDegenfrom the degen section to before the pools, unchanged.sharedMindOverMatteris set, a new check adds up the part of each self degen that reaches ES: the degen times (1 -<type>EnergyShieldBypass/ 100). With Eldritch Battery, only the part that Mind over Matter takes from mana counts.EnergyShieldRegenRecovery, the check setsEnergyShieldDepletedByDegenandCappingES, and setsEnergyShieldRecoveryCapto 0. Every hit pool reads that cap, and EHP and Maximum Hit Taken come from the pools. Maximum ES does not change, so RF's damage to enemies and the degen itself stay the same. Calcs shows the breakdown on the Total Recoverable row of the Energy Shield section.EnergyShieldRegenRecovery, such as leech or recoup. The check is on by default; whether it should be is your call.Builds whose ES regeneration covers the degen, including Zealot's Oath with enough life regeneration, keep their ES. Chaos Inoculation builds are unaffected because PoB gives RF no degen under Chaos Inoculation (#9110). The check counts every self degen that reaches ES, so Blood Rage also drops ES out of EHP on an ES build with no ES regeneration.
This PR leaves the degen split alone (see #2854). When ES regeneration is above 0 but below the degen, the degen section still puts the whole degen on ES and none on life.
Steps taken to verify a working solution:
TestDefence_spec.lua: no degen, RF draining ES (including the Configuration checkbox), regeneration that does and does not cover the degen, full and 50% non-chaos ES bypass, Zealot's Oath, Chaos Inoculation, and Eldritch Battery with and without Mind over Matter. The RF, regeneration and bypass specs fail on currentdev, and all seven pass with this change.pathofbuilding-testsimage: 673 of 674 pass. The one failure, "Veiled unique affix pools only offers attainable modifiers on That Which Was Taken", also fails on currentdevin the same image.Link to a build that showcases this PR:
Before screenshot:
None.
After screenshot:
None.