Skip to content

move the coercion of i into .dt_coerce_i() - #7945

Open
ben-schwen wants to merge 1 commit into
brk/b1_isubfrom
brk/b2_coerce_i
Open

ben-schwen wants to merge 1 commit into
brk/b1_isubfrom
brk/b2_coerce_i

Conversation

@ben-schwen

Copy link
Copy Markdown
Member

Towards #852

@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (cc64765) to head (9e62363).

Additional details and impacted files
@@             Coverage Diff              @@
##           brk/b1_isub    #7945   +/-   ##
============================================
  Coverage        99.09%   99.09%           
============================================
  Files               88       88           
  Lines            17459    17467    +8     
============================================
+ Hits             17301    17309    +8     
  Misses             158      158           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
  • HEAD=brk/b2_coerce_i much slower for Date-IDate regression in #7213

(Plot image upload to picrd.com failed; download the artifact below to view plots)

Generated via commit 9e62363

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 31 seconds
Installing different package versions 48 seconds
Running and plotting the test cases 6 minutes and 9 seconds

@ben-schwen
ben-schwen removed this pull request from stack #7933 November 3, 2026 09:15
@ben-schwen
ben-schwen added this pull request to stack #7953 November 3, 2026 09:16
@ben-schwen
ben-schwen force-pushed the brk/b2_coerce_i branch 2 times, most recently from b641e0c to 2b97422 Compare November 3, 2026 09:51
@ben-schwen
ben-schwen force-pushed the brk/b2_coerce_i branch 4 times, most recently from 3b5b2b2 to eebacb8 Compare November 3, 2026 17:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant