Repository navigation
Conversation
- Link the MapLibre three.js example at its last version. MapLibre removed it and now only shows three.js through maplibre-gl-three, so the old URL is a 404 and no current page shows the raw custom layer code. - Point the R3F docs links to r3f.docs.pmnd.rs, where docs.pmnd.rs redirects. - Point the Examples badge to the existing canvas--maplibre story. - Turn the two mentions of PR 102 into links; README files don't autolink them. - Fix spelling and grammar (ton, below, unnecessary, separate, "how complex it is", MapLibre/Mapbox), a duplicate import in the basic example and a stray "?" in the size badge URL.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just wanted to fix the broken ThreeJS object example link, Claude found some other typos and broken/redirected links.
Fixes typos and broken links in
README.mdandstories/README.md, plus one typo inCHANGELOG.md. No code changes.Broken links
maplibre.org/maplibre-gl-js-docs/example/add-3d-model/returns 404). MapLibre renamed the example in 2025 and deleted it in October 2026 (maplibre-gl-js commit f98ef79). Its three.js examples now use themaplibre-gl-threehelper library, so no page on maplibre.org still shows the low-level custom-layer code that the "how complex" sentence is about. The link now points to Mapbox's live Add a 3D model with three.js example, which builds the same kind of custom layer by hand. The original MapLibre page is still on the Wayback Machine (snapshot from 14 March 2023) if you'd rather link that.canvas--a-maplibre-exampleno longer exists on the Ladle site. The badge now openscanvas--maplibre.docs.pmnd.rs/react-three-fiber/…redirects tor3f.docs.pmnd.rs. The two links now point there directly; the#createrootanchor still exists.?from the badge's query string.Typos and grammar
useRefanduseStatetwice, which doesn't compilestories/README.md, "coordiantes" inCHANGELOG.mdHow it was checked
meta.json.Not changed
Older changelog entries that state something wrong were left as release history:
frameloop="ondemand", but the value is"demand".🤖 Generated with Claude Code