Repository navigation
Reintroduced old hit finder parameters for SPINE reconstruction - #934
Closed
mattiasotgia wants to merge 3 commits into
Closed
mattiasotgia wants to merge 3 commits into
mattiasotgia wants to merge 3 commits into
Conversation
Contributor
Author
|
Converting this to draft since there've been some developments that lead to halt this PR, and this way it is clear this should not be merged for now. |
Contributor
Author
|
Closing this PR, superseeded by #938 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings back the old setof parameters for the hit finder algorithm modules used as input to the SPINE reconstruction chain.
This was mentioned at the CM sim/reco talk (link here) and brought up to experts.
Requesting a review to @acampani and @SFBayLaser (since this is the SPINE phase space + he was involved in the whole work of retuning the parameters for the hit finder)