Repository navigation
CMakeLists.txt: sbnanaobj package exported - #686
Closed
PetrilloAtWork wants to merge 1 commit into
Closed
PetrilloAtWork wants to merge 1 commit into
PetrilloAtWork wants to merge 1 commit into
Conversation
This works around the issue where CMake requires `sbnanaobj` for any build where `sbncode` is included, regardless on whether that is actually used or not (e.g., in icaruscode it is not). This change allows the dependent build to succeed even when they don't explicitly include sbnanaobj (because *they* don't need it).
Contributor
|
This issue was independently resolved in sbncode v10_31_00_02 (no specific PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around the issue where CMake requires
sbnanaobjfor any build wheresbncodeis included, regardless on whether that is actually used or not (e.g., in icaruscode it is not). This change allows the dependent build to succeed even when they don't explicitly include sbnanaobj (because they don't need it).