Skip to content

Gen2 Production PR: Update to SBND LightPropagation Module - #967

Open
VCLanNguyen wants to merge 3 commits into
production/sbnd-gen2from
bugfix_gen2_mctiming_merge_correctedopflash
Open

Gen2 Production PR: Update to SBND LightPropagation Module#967
VCLanNguyen wants to merge 3 commits into
production/sbnd-gen2from
bugfix_gen2_mctiming_merge_correctedopflash

Conversation

@VCLanNguyen

@VCLanNguyen VCLanNguyen commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  1. Update cafmakerjob_sbnd_data_sce.fcl to pick up the correct SCE label
  2. Reorder reco2_data.fcl to run FrameShift module before LightPropagation module
  3. Update LightPropogation to pick FrameShift products

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{blue}\bf{\textrm{IMPORTANT UPDATE Feb 2nd 2026:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production for gen 2 SBND analyses, you must make two PRs: one for develop and one for the production/sbnd-gen2 branch.

$${\color{red}\bf{\textrm{RESPONSE:}}}$$ This PR is unique to gen2 production. For develop, the FrameShift module is run at decoder level and every downstream products inherit it. For more information, see docdb#45982

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Relevant PR links (optional)

sbndcode: #967
sbncode: SBNSoftware/sbncode#675
sbnanaobj: SBNSoftware/sbnanaobj#199

Link(s) to docdb describing changes (optional)

See slide 27-29 on docdb#49588

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or tjones79) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

@VCLanNguyen @claude
Fix data-side CorrectedOpFlash timing: SCE label and RWM-to-gate alig…
ad2ce28 
…nment

cafmakerjob_sbnd_data_sce.fcl was not remapping CorrectedOpFlashLabel to
its SCE variant, so CAFMaker's association lookup used a label nothing
produced ("lightpropagationcorrection" instead of
"lightpropagationcorrectionSCE"), leaving correctedOpFlash.* at the
-9999. sentinel in data.

LightPropagationCorrection_module now reads the sbnd::timing::FrameShiftInfo
product (produced by FrameShift_module, reordered earlier in
reco2_data.fcl's physics.reco2 path) instead of computing its own shift
from raw SPECTDC RWM/trigger hits. This picks up the RWM-to-gate alignment
FrameShift_module already applies (including the ~1738ns BNBLight mean)
and is stream-agnostic (BNB/Offbeam/Xmuon) since FrameApplyAtCaf is
resolved per-stream upstream. The FrameShiftInfo read is now done once per
event before the slice loop rather than once per slice.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
@VCLanNguyen
VCLanNguyen marked this pull request as draft September 30, 2026 18:54
@VCLanNguyen VCLanNguyen mentioned this pull request Sep 30, 2026
Merged
3 of 6 tasks
@VCLanNguyen VCLanNguyen changed the title Fix data-side CorrectedOpFlash timing: SCE label and RWM-to-gate alig… Gen2 Production PR: 1. Manual Fix for GENIE timing bug in CAFMaker, 2. Extend existing-data shift in CAFMaker, 3. Update to SBND LightPropagation Module Sep 30, 2026
@VCLanNguyen VCLanNguyen changed the title Gen2 Production PR: 1. Manual Fix for GENIE timing bug in CAFMaker, 2. Extend existing-data shift in CAFMaker, 3. Update to SBND LightPropagation Module Gen2 Production PR: Update to SBND LightPropagation Module Sep 30, 2026
@VCLanNguyen VCLanNguyen self-assigned this Sep 30, 2026
@VCLanNguyen VCLanNguyen added pds Photon Detection System data features for data processing labels Sep 30, 2026
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Gen2 Production Oct 1, 2026
@VCLanNguyen VCLanNguyen mentioned this pull request Oct 1, 2026
Merged
5 tasks done
@VCLanNguyen
VCLanNguyen marked this pull request as ready for review October 1, 2026 18:48
@asanchezcastillo asanchezcastillo mentioned this pull request Oct 20, 2026
Merged
6 of 7 tasks
@asanchezcastillo asanchezcastillo self-assigned this Oct 20, 2026
@asanchezcastillo
asanchezcastillo requested review from fjnicolas and removed request for asanchezcastillo October 20, 2026 13:42
@asanchezcastillo

asanchezcastillo commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Pinging @fjnicolas as reviewer since @VCLanNguyen and myself are PR authors.

@aantonakis

aantonakis commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10

@FNALbuild

FNALbuild commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis

aantonakis commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Hi @fjnicolas, we are hoping to merge this PR soon. I just wanted to reach out to see if you could give this a review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjnicolas fjnicolas Awaiting requested review from fjnicolas

At least 1 approving review is required to merge this pull request.

Assignees

@VCLanNguyen VCLanNguyen

@asanchezcastillo asanchezcastillo

Labels

data features for data processing pds Photon Detection System

Projects

SBND 2025 Gen2 Production
Status: Waiting on Reviewer

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VCLanNguyen @asanchezcastillo @aantonakis @FNALbuild