Repository navigation
Fix Theme Check errors for unknown extended configs - #9114
Open
MillanWangShopify wants to merge 1 commit into
Open
MillanWangShopify wants to merge 1 commit into
MillanWangShopify wants to merge 1 commit into
Conversation
MillanWangShopify
force-pushed
the
torrent/cli-8-show-a-clear-error-when-a-theme-check-co
branch
from
November 10, 2026 02:56
4fb1de6 to
5394ae8
Compare
Handle missing extended configs without masking unrelated Theme Check failures. Recognize identifiers in Windows readFile paths and normalize missing extended config paths for consistent output. Refresh generated App Logs types to match the live schema required by CI. Co-authored-by: Millan Wang <millan.wang@shopify.com>
MillanWangShopify
force-pushed
the
torrent/cli-8-show-a-clear-error-when-a-theme-check-co
branch
from
November 10, 2026 03:06
5394ae8 to
42fdd36
Compare
MillanWangShopify
marked this pull request as ready for review
November 10, 2026 03:32
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
A
.theme-check.ymlfile that extendstheme-check:shopifymakesshopify theme checkfail with an unhandledENOENT. A missing extended config file has the same problem, including when no--configflag is given.WHAT is this pull request doing?
Show a handled error that names the missing config and lists the built-in configs. Verify missing file errors against config loading so unrelated Theme Check failures keep their original error. Add regression tests with real config files. Refresh the generated App Logs types to match the schema used by CI.
Before:
After:
How to manually test your changes?
.theme-check.ymltoextends: theme-check:shopify.pnpm shopify theme check --path /path/to/themewithout--config. Confirm the error namestheme-check:shopifyand lists the built-in configs.extends: ./missing.ymland run the command again. Confirm the error names the missing config file.extends: theme-check:recommendedand confirm Theme Check runs normally.Checklist
patchfor this bug fix) and added a changeset