Skip to content

Fix pdm e2e red on every PR: pin hishel<2 #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikola Lysenko (mikolalysenko) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pdm e2e red on every PR: pin hishel<2 #2028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/socket-patch-cli/tests/e2e_vex_build/pdm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,14 @@ fn pins_for(v: &str) -> Vec<String> {
// 2.26.9+ require 1.x).
if ((2, 21, 0)..(2, 26, 1)).contains(&t) {
pins.push("hishel<1");
} else if t >= (2, 26, 1) {
// 2.26.9+ declare an unbounded `hishel>=1.0.0` (2.29.6:
// `>=1.4.0`), and hishel 2.0 (2026-11-05) dropped
// `SyncSqliteStorage`, so every command dies with "module
// 'hishel' has no attribute 'SyncSqliteStorage'". `<2`
// resolves the 1.x line those releases shipped against (a
// no-op for 2.26.1 - 2.26.8, which already bound `<1`).
pins.push("hishel<2");
}
// 2.x declares an unbounded `unearth`, and unearth 0.19 (2026-10-27)
// moved to `httpx2`: PDM's PyPI client is no longer the `httpx`
Expand Down
6 changes: 6 additions & 0 deletions scripts/backtest-pdm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,12 @@ def pins_for(version):
# ModuleNotFoundError before locking.
if (2, 21) <= v < (2, 26, 1):
pins.append("hishel<1")
# 2.26.9+ declare an unbounded `hishel>=1.0.0` (2.29.6: `>=1.4.0`);
# hishel 2.0 (2026-11-05) dropped `SyncSqliteStorage` and every
# command dies with AttributeError. `<2` keeps the 1.x line (a
# no-op for 2.26.1 - 2.26.8, which already bound `<1`).
elif v >= (2, 26, 1):
pins.append("hishel<2")
# 2.x declares an unbounded `unearth`; 0.19 (2026-10-27) moved to
# httpx2 and breaks PDM's PyPI client ("PDMPyPIClient is not an
# instance or subtype of type (Client)" on `pdm lock`, seen on
Expand Down
Loading