Skip to content

Add error-state component for errors, improve errors and fix loading - #239

Merged
SharonStrats merged 1 commit into
stagingfrom
fix-editor-loading
Nov 4, 2026
Merged

SharonStrats merged 1 commit into
stagingfrom
fix-editor-loading

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

took the opportunity to add the error-state component while fixing the load issue.

@SharonStrats
SharonStrats requested a balanced review from Copilot November 4, 2026 06:20
@SharonStrats SharonStrats self-assigned this Nov 4, 2026
@SharonStrats SharonStrats added the bug Something isn't working label Nov 4, 2026
@SharonStrats SharonStrats linked an issue Nov 4, 2026 that may be closed by this pull request
@SharonStrats SharonStrats moved this to In review in SolidOS NLNet UI Nov 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the editor startup failure-handling changes.

No open issues 🎉

What changed in this PR

This PR improves source-editor startup failure handling with a shared error-state component, pane-scoped messages, and recovery guidance.

Changes:

  • Adds retry controls, expandable diagnostics, and console logging for editor startup failures.
  • Prevents detached panes from displaying late errors and adds regression tests for failure handling.
  • Documents troubleshooting steps, simplifies status styling, and refreshes locked dependencies.
File Description
test/​sourcePaneLoading.test.js Tests diagnostics, retry, dismissal, and detached-pane isolation.
src/​StatusSection.ts Uses solid-ui-error-state with pane-scoped status, retry, and details.
src/​StatusSection.css Removes replaced error styling and enables diagnostic text wrapping.
src/​sourcePane.ts Adds guarded editor loading, retry handling, and structured error logging.
README.md Documents startup recovery and troubleshooting.
package-lock.json Updates several transitive dependency versions.

Review effort: Balanced

…editor

Prompt: There is sometimes a problem bringing up the editor

Co-authored-by: GPT-5.6 Luna <[email protected]>
@SharonStrats
SharonStrats merged commit d6b8e5b into staging Nov 4, 2026
8 checks passed
@SharonStrats
SharonStrats deleted the fix-editor-loading branch November 4, 2026 06:52
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Storage: Error message on opening a resource

2 participants