Repository navigation
Add error-state component for errors, improve errors and fix loading - #239
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the editor startup failure-handling changes.
No open issues 🎉
What changed in this PR
This PR improves source-editor startup failure handling with a shared error-state component, pane-scoped messages, and recovery guidance.
Changes:
- Adds retry controls, expandable diagnostics, and console logging for editor startup failures.
- Prevents detached panes from displaying late errors and adds regression tests for failure handling.
- Documents troubleshooting steps, simplifies status styling, and refreshes locked dependencies.
| File | Description |
|---|---|
test/sourcePaneLoading.test.js |
Tests diagnostics, retry, dismissal, and detached-pane isolation. |
src/StatusSection.ts |
Uses solid-ui-error-state with pane-scoped status, retry, and details. |
src/StatusSection.css |
Removes replaced error styling and enables diagnostic text wrapping. |
src/sourcePane.ts |
Adds guarded editor loading, retry handling, and structured error logging. |
README.md |
Documents startup recovery and troubleshooting. |
package-lock.json |
Updates several transitive dependency versions. |
Review effort: Balanced
…editor Prompt: There is sometimes a problem bringing up the editor Co-authored-by: GPT-5.6 Luna <[email protected]>
SharonStrats
force-pushed
the
fix-editor-loading
branch
from
November 4, 2026 06:50
440c53b to
9291bae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
took the opportunity to add the error-state component while fixing the load issue.