Repository navigation
error status refactor and accessibility - #240
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The loading state exposes the previous resource’s editor content and Save button, allowing stale content to be saved to the newly selected resource’s URI.
6 open issues
Hide stale editor and Save controls while loading a resource · New Refresh editor accessibility labels on read-only transitions · New Preserve metadata refresh warning after a successful save · New Clear loading state when editor initialization fails · New Build and display the final character-position error once · New Clear the pane busy state when import fails · New
What changed in this PR
This PR refactors Source Pane status handling and improves accessibility for editing, loading, and save/cancel feedback.
Changes:
- Scopes status and error messages to individual panes and adds success notifications.
- Adds accessible labels, busy states, loading announcements, and focus restoration.
- Extends tests for status isolation and editor accessibility.
| File | Description |
|---|---|
test/statusSection.test.js |
Tests status rendering, error replacement, and pane isolation. |
test/sourceEditorCard.test.js |
Checks accessible labels, initialization options, and cancel focus. |
src/StatusSection.ts |
Adds non-error messages and live-region attributes. |
src/sourcePane.ts |
Adds a labeled region and module-loading busy state. |
src/helpers.ts |
Scopes errors and replaces caret positioning with location messages. |
src/components/source-editor-card/SourceEditorCard.ts |
Adds editor accessibility metadata, scoped feedback, and focus restoration. |
src/components/source-editor-card/SourceEditorCard.styles.css |
Revises loading visibility and styles screen-reader loading text. |
Review effort: Balanced
SharonStrats
force-pushed
the
feat/accessibility
branch
2 times, most recently
from
November 10, 2026 01:03
751ca57 to
7c7bceb
Compare
SharonStrats
force-pushed
the
feat/accessibility
branch
from
November 10, 2026 07:14
24db46a to
688d7b9
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The footer remains actionable during loading, allowing Save to write stale editor content to the current resource during reloads or resource switches.
1 open issue
6 resolved since last review
Hide stale editor and Save controls while loading a resource Clear the pane busy state when import fails Build and display the final character-position error once Clear loading state when editor initialization fails Preserve metadata refresh warning after a successful save Refresh editor accessibility labels on read-only transitions
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Code clean up for error status and make it a bit nicer.
meet WCAG requirements
change mobile breakpoint from 600 to 768 like everything else.