Skip to content

error status refactor and accessibility - #240

Merged
SharonStrats merged 3 commits into
stagingfrom
feat/accessibility
Nov 10, 2026
Merged

SharonStrats merged 3 commits into
stagingfrom
feat/accessibility

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Code clean up for error status and make it a bit nicer.

meet WCAG requirements

change mobile breakpoint from 600 to 768 like everything else.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The loading state exposes the previous resource’s editor content and Save button, allowing stale content to be saved to the newly selected resource’s URI.

6 open issues
What changed in this PR

This PR refactors Source Pane status handling and improves accessibility for editing, loading, and save/cancel feedback.

Changes:

  • Scopes status and error messages to individual panes and adds success notifications.
  • Adds accessible labels, busy states, loading announcements, and focus restoration.
  • Extends tests for status isolation and editor accessibility.
File Description
test/​statusSection.test.js Tests status rendering, error replacement, and pane isolation.
test/​sourceEditorCard.test.js Checks accessible labels, initialization options, and cancel focus.
src/​StatusSection.ts Adds non-error messages and live-region attributes.
src/​sourcePane.ts Adds a labeled region and module-loading busy state.
src/​helpers.ts Scopes errors and replaces caret positioning with location messages.
src/​components/​source-editor-card/​SourceEditorCard.ts Adds editor accessibility metadata, scoped feedback, and focus restoration.
src/​components/​source-editor-card/​SourceEditorCard.styles.css Revises loading visibility and styles screen-reader loading text.

Review effort: Balanced

Comment thread src/helpers.ts Resolved
Comment thread src/sourcePane.ts Resolved
@SharonStrats
SharonStrats force-pushed the feat/accessibility branch 2 times, most recently from 751ca57 to 7c7bceb Compare November 10, 2026 01:03
@SharonStrats SharonStrats added the enhancement New feature or request label Nov 10, 2026
@SharonStrats SharonStrats moved this to In review in SolidOS NLNet UI Nov 10, 2026
@SharonStrats SharonStrats linked an issue Nov 10, 2026 that may be closed by this pull request
@SharonStrats
SharonStrats requested a balanced review from Copilot November 10, 2026 07:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>
@SharonStrats SharonStrats linked an issue Nov 10, 2026 that may be closed by this pull request
@SharonStrats
SharonStrats merged commit fa1dfc3 into staging Nov 10, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Nov 10, 2026
@SharonStrats
SharonStrats deleted the feat/accessibility branch November 10, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Source pane - WCAG requirements Refactor error section and add styling

2 participants