Skip to content

ci: fail the Branch protection check when a job it waits on does not succeed #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armando-navarro merged 2 commits into from
Nov 6, 2026
Merged

ci: fail the Branch protection check when a job it waits on does not succeed #3840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30efd6c
ci: fail the Branch protection check when a job it waits on does not …
armando-navarro Nov 5, 2026
99c7c92
Merge branch 'main' into ci-branch-protection-always-runs
armando-navarro Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,13 @@
runs-on: ubuntu-latest
name: Branch protection
needs: ['test', 'contribute', 'browser', 'firebase-13']
# A skipped job satisfies a required status check, so this job must run on every outcome of
# the jobs above and fail itself. Keep always(), not !cancelled(): a cancelled run must stay red.
if: ${{ always() }}
steps:
- run: true
- name: Fail unless every needed job succeeded
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'skipped') }}
run: exit 1

publish:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -239,7 +244,7 @@
- name: Publish
id: publish
if: steps.canary_check.outputs.skip != 'true' && steps.release_tag.outputs.published != 'true'
run: npm publish ./dist/packages-dist --access public --registry https://wombat-dressing-room.appspot.com --tag "$NPM_TAG"

Check notice on line 247 in .github/workflows/test.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

use-trusted-publishing 

test.yml:247: prefer trusted publishing for authentication: this command
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NPM_TAG: ${{ steps.release_tag.outputs.tag || 'canary' }}
Expand Down
Loading