Repository navigation
Conversation
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This PR increases the startup wait timeout in sdks/python/scripts/run_expansion_services.sh from 60 seconds to 180 seconds. This resolves flaky timeouts during cross-language runner setup when the Python expansion service experiences transient PyPI network retries while downloading test dependencies (beautifulsoup4) before binding its gRPC port.
🔍 General Feedback
- The root cause analysis and timeout adjustment are clear, well-scoped, and safe to merge.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41219 +/- ##
=========================================
Coverage 58.54% 58.54%
Complexity 2277 2277
=========================================
Files 1132 1132
Lines 169699 169712 +13
Branches 1485 1485
=========================================
+ Hits 99351 99361 +10
- Misses 67806 67809 +3
Partials 2542 2542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Fixes
Timed out waiting 60s for Python expansion servicefailures invalidatesCrossLanguageRunnerSetupacrossPostCommit XVR PythonUsingJava Dataflow(run 43071232200 and run 42591167549).Root Cause
Before
apache_beam.runners.portability.expansion_service_testbinds its gRPC server port,ExpansionServiceServicerinitializes its default environment and invokespip download beautifulsoup4>=4.9,<5.0(as well as fitting the testsklearnSVM artifact). When PyPI experiences a transient socket timeout/retry (pip's default timeout is 15s × up to 5 retries = 75s),wait_for_portinsdks/python/scripts/run_expansion_services.shtimes out at 60s before the server starts listening.Fix
Increase the
wait_for_porttimeout insdks/python/scripts/run_expansion_services.shfrom 60s to 180s.Verification
beam_PostCommit_XVR_PythonUsingJava_Dataflow.ymlworkflow run on branch:43083880271