Repository navigation
Conversation
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR pins pyarrow<26 in .github/workflows/run_perf_alert_tool.yml to resolve an ImportError caused by pyarrow>=26 requiring NumPy 2.0+ while signal-processing-algorithms constrains numpy<2.0.0. The change is minimal, targeted, and aligns with the NumPy 1 environment pins in sdks/python/tox.ini.
🔍 General Feedback
- No other workflows or test environments install
signal-processing-algorithms, so scoping this pin torun_perf_alert_tool.ymlis sufficient and appropriate. - LGTM!
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance alerting tool on Python load/performance/benchmark tests.failure in https://github.com/apache/beam/actions/runs/43109552076.pyarrowupper bound insetup.pyto<27.0.0and pinnedpyarrow<26intox.inifor NumPy 1 environments),pip install -e .[gcp,test]inrun_perf_alert_tool.ymlinstallspyarrow 26.0.1, and the subsequentpip install signal-processing-algorithmsstep downgradesnumpyto1.26.4(signal-processing-algorithmsrequiresnumpy<2.0.0).perf_analysis.pyimportsdb_dtypes->pyarrow, it fails withImportError: pyarrow requires NumPy 2.0 or newer, found 1.26.4."pyarrow<26"inrun_perf_alert_tool.ymlto match the NumPy 1 environments intox.ini.Test Plan
run_perf_alert_tool.ymlon this PR branch.Verification
run_perf_alert_tool.ymlworkflow run on branch:43119916176